NotificationsYou must be signed in to change notification settings
Fork361
Star8.1k

Remove declaration dir warning when declarations are disabled#912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

andyrichardson wants to merge1 commit intodevelopit:master

base:master

Choose a base branch

fromandyrichardson:patch-1

Open

Remove declaration dir warning when declarations are disabled#912

andyrichardson wants to merge1 commit intodevelopit:masterfromandyrichardson:patch-1

Conversation

Copy link

andyrichardson commentedNov 25, 2021

About

Given the following tsconfig

{"compilerOptions": {"declaration":false  }}

The user will see this message whenever building

rpt2: options error TS5069: Option 'declarationDir' cannot be specified without specifying option 'declaration' or option 'composite'.

This PR introduces a check to only provide adeclarationDir option to rollup if declarations aren't omitted.

Other stuff

This is just a proposal - thetsconfig.json would need to be properly interpreted in order to get thedeclaration value (e.g. to coverextends).

Remove declaration dir warning when declarations are disabled

7f35910

Copy link

changeset-botbot commentedNov 25, 2021

⚠️ No Changeset found

Latest commit:7f35910

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Collaborator

rschristian commentedNov 30, 2021•
edited
Loading

I'm thinking we can just alteremitDeclaration to check fortsconfig.compilerOptions.declaration too (and accordingly changethe condition for addingdeclarationDir toemitDeclaration)

Checkoptions.generateTypes thentsconfig.compilerOptions.declaration and finally!!(pkg.types || pkg.typings). That should cover all the bases

Edit: The case ofextends might be something that's acceptable to skip over for now. Mono-repo support (which is where I imagine the need for extending most often comes from) is already pretty limited by rpt2, making Microbundle not the best tool to use if that's the need.

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove declaration dir warning when declarations are disabled#912

Are you sure you want to change the base?

Remove declaration dir warning when declarations are disabled#912

Uh oh!