- Notifications
You must be signed in to change notification settings - Fork361
Add example folder#366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR, but what problem are you trying to solve here? Storybook is still using webpack to build it's things. So really all you're showing here is that Maybe this can be an example you could maintain in your own personal land, and we can ask@developit if we could reference it in the readme or something. All in all, the maintainers here wouldn't want to now maintain examples, and test that all the examples still work etc... |
thanks for the response@maraisr ! my first approach was what you said:#365. I think this is cleaner for the proyect too. I'm happy to reopen/update/delete this PRs. I found examples really useful for newcomers to the project, and check how the setup (specially the setup) is done is really helpful. Hope we can give the community a way to publish more examples as this one! Let me know what you think 👍 |
I'd love a microbundle-examples repo. |
devinrhode2 commentedMar 29, 2023
Storybook now has a vite builder, whichcan replace webpack. Vite is mostly based on Rollup, with some esbuild sprinkled in where possible. I wonder if Microbundle could be implemented on top of vite? |
add an example folder to share project configurations using microbundle.
the example I added is using:
hopefully this will be helpful for new devs :)