Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updates (particularly for spdx-correct and spdx-satisfies)#25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
brettz9 wants to merge1 commit intodelfrrr:master
base:master
Choose a base branch
Loading
frombrettz9:updates
Open

Conversation

@brettz9
Copy link

  • Linting (ESLint): Apply per latest airbnb-base (import order, destructuring, no useless else, line breaks in destructured params, prefer spread)
  • Linting (ESLint): Add ignore file in conjunction with linting all by default (catches index.js)
  • npm: Update eslinting devDeps to latest major versions
  • npm: Update spdx-correct, and spdx-satisfies to latest major versions
  • npm: Update other deps. to latest minor version
  • Travis: Update per newest minimum (and add 10 and 12)

The main changes here are the major version bumps forspdx-correct andspdx-satisfies.

Forspdx-correct, the major bump occurred with updates to:

  1. spdx-license-ids (which moved out some now deprecated licenses):jslicense/spdx-license-ids@b9f544d and changes to the IDS per a new build:https://github.com/shinnn/spdx-license-ids/pull/8/files . I think this is reasonable unless you wanted to allow checking against deprecated licenses.
  2. spdx-expression-parse which also updated itsspdx-license-ids but used them to determine validity. I think the advantage of supporting any newer types outweighs and disadvantages of missing any older types. It also updatedspdx-exceptions but this was a minor change and looking at the source, it doesn't appear it should affect anything.

As far asspdx-satisfies, it has incremented several major versions, updating its copy ofspdx-correct. You'd have to go through the other changes if you want an exact picture, but the API of passing two arguments is still the same, and I expect it should be doing better than before at checking whether the expressions satisfy the license criteria.

The other updates just need assuming that the minor/patch versions are ok, and assuming you are ok with moving to Node 8.3 (I know Travis is 8, but the spread syntax recommended now by airbnb requires 8.3, and Node 8 just entered EOL anyways, so really should upgrade to 10), I think these changes should all be good. (Without existing tests, it is harder to know, but as per the above, I have tried to ascertain the safety of these changes. I am using my fork and it hasfixed#21 for me withgetLicenseType.)

mifi reacted with thumbs up emoji
…ucturing, no useless else, line breaks in destructured params, prefer spread)- Linting (ESLint): Add ignore file in conjunction with linting all by default (catches index.js)- npm: Update eslinting devDeps to latest major versions- npm: Update spdx-correct, and spdx-satisfies to latest major versions- npm: Update other deps. to latest minor version- Travis: Update per newest minimum (and add 10 and 12)
@brettz9brettz9 mentioned this pull requestJan 7, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handling of "OR"

1 participant

@brettz9

[8]ページ先頭

©2009-2025 Movatter.jp