This repository was archived by the owner on Feb 10, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork1.1k
This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Suboptimal use of Promise in client.js #257
Open
Description
What is the current behavior?
If the current behavior is a bug, please provide the exact steps to reproduce.
What is the expected behavior?
Additional context
Add any other context about the problem here.
The methods buildMap(), start(), uploadImage() use new Promise, although Promise.all() returns a Promise anyway.
For example, in start():
return new Promise(async (resolve) => {
const assets = await Promise.all(this.loadAssets());
resolve(assets);
});
Metadata
Metadata
Assignees
Labels
No labels