- Notifications
You must be signed in to change notification settings - Fork126
SEA: normalise column names in metadata queries#661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
varun-edachali-dbx wants to merge25 commits intomainChoose a base branch fromcol-normalisation
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
25 commits Select commitHold shift + click to select a range
9de6c8b init col norm
varun-edachali-dbxf5982f0 partial working dump
varun-edachali-dbxd97d875 refactor
varun-edachali-dbxc5c9859 remove callback methods for transformations
varun-edachali-dbx311e217 merge with main
varun-edachali-dbx2b1442f remove redundant COLUMN_DATA_MAPPING
varun-edachali-dbx1d515e3 rename transformation functions to normalise for metadata cols
varun-edachali-dbx2be0c86 make mock result set be of type SeaResultSet
varun-edachali-dbx92c2da4 remove redundant comments
varun-edachali-dbx99481e9 use SqlType for type conv
varun-edachali-dbxf90a75e verified: get catalogs
varun-edachali-dbx946e513 verif: get schemas
varun-edachali-dbx070b931 verif: TABLE_COLUMNS from jdbc
varun-edachali-dbx939c542 verif: COLUMN_COLUMNS from JDBC
varun-edachali-dbx7d3174f make stuff missing from SEA None in SEA mapping
varun-edachali-dbx82e9c4f remove hardcoding in SqlType
varun-edachali-dbxb2ae83c move helper type name extractor out of class
varun-edachali-dbx9fb0444 Merge branch 'main' into col-normalisation
varun-edachali-dbx4be6808 ensure SeaResultSet resp
varun-edachali-dbx0dad966 clean up conversion code
varun-edachali-dbxa28596b fix type codes
varun-edachali-dbx639bafa simplify docstring
varun-edachali-dbxb0b58fb nit: reduce repetition
varun-edachali-dbx55d8c75 test metadata mappings
varun-edachali-dbxce591ce Merge branch 'main' into col-normalisation
varun-edachali-dbxFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
22 changes: 18 additions & 4 deletionssrc/databricks/sql/backend/sea/backend.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
126 changes: 125 additions & 1 deletionsrc/databricks/sql/backend/sea/result_set.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
56 changes: 32 additions & 24 deletionssrc/databricks/sql/backend/sea/utils/conversion.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.