Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitb3072bd

Browse files
reduce diff
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parentc7810aa commitb3072bd

File tree

4 files changed

+7
-17
lines changed

4 files changed

+7
-17
lines changed

‎src/databricks/sql/session.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,10 @@ def open(self):
126126
catalog=self.catalog,
127127
schema=self.schema,
128128
)
129+
129130
self.protocol_version=self.get_protocol_version(self._session_id)
130131
self.is_open=True
131-
logger.info("Successfully opened session"+str(self.guid_hex))
132+
logger.info("Successfully opened session%s",str(self.guid_hex))
132133

133134
@staticmethod
134135
defget_protocol_version(session_id:SessionId):

‎src/databricks/sql/types.py‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ def __contains__(self, item: Any) -> bool:
187187
# let object acts like class
188188
def__call__(self,*args:Any)->"Row":
189189
"""create new Row object"""
190-
191190
iflen(args)>len(self):
192191
raiseValueError(
193192
"Can not create Row with fields %s, expected %d values "
@@ -230,15 +229,13 @@ def __reduce__(
230229
self,
231230
)->Union[str,Tuple[Any, ...]]:
232231
"""Returns a tuple so Python knows how to pickle Row."""
233-
234232
ifhasattr(self,"__fields__"):
235233
return (_create_row, (self.__fields__,tuple(self)))
236234
else:
237235
returntuple.__reduce__(self)
238236

239237
def__repr__(self)->str:
240238
"""Printable representation of Row used in Python REPL."""
241-
242239
ifhasattr(self,"__fields__"):
243240
return"Row(%s)"%", ".join(
244241
"%s=%r"% (k,v)fork,vinzip(self.__fields__,tuple(self))

‎tests/unit/test_client.py‎

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -105,17 +105,13 @@ def test_closing_connection_closes_commands(self, mock_thrift_client_class):
105105

106106
# Mock the execute response with controlled state
107107
mock_execute_response=Mock(spec=ExecuteResponse)
108-
109-
mock_execute_response.command_id=Mock(spec=CommandId)
110-
mock_execute_response.status= (
111-
CommandState.SUCCEEDEDifnotclosedelseCommandState.CLOSED
112-
)
108+
mock_execute_response.status=initial_state
113109
mock_execute_response.has_been_closed_server_side=closed
114110
mock_execute_response.is_staging_operation=False
115111
mock_execute_response.command_id=Mock(spec=CommandId)
116112
mock_execute_response.description= []
117113

118-
# Mock the backend that will be used by the real ThriftResultSet
114+
# Mock the backend that will be used
119115
mock_backend=Mock(spec=ThriftDatabricksClient)
120116
mock_backend.staging_allowed_local_path=None
121117
mock_backend.fetch_results.return_value= (Mock(),False,0)
@@ -137,15 +133,13 @@ def test_closing_connection_closes_commands(self, mock_thrift_client_class):
137133
# Mock execute_command to return our real result set
138134
cursor.backend.execute_command=Mock(return_value=real_result_set)
139135

140-
# Execute a command - this should set cursor.active_result_set to our real result set
136+
# Execute a command
141137
cursor.execute("SELECT 1")
142138

143-
# Close the connection - this should trigger the real close chain:
144-
# connection.close() -> cursor.close() -> result_set.close()
139+
# Close the connection
145140
connection.close()
146141

147-
# Verify the REAL close logic worked through the chain:
148-
# 1. has_been_closed_server_side should always be True after close()
142+
# Verify the close logic worked:
149143
assertreal_result_set.has_been_closed_server_sideisTrue
150144

151145
# 2. op_state should always be CLOSED after close()

‎tests/unit/test_cloud_fetch_queue.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,6 @@ def test_next_n_rows_0_rows(self, mock_create_next_table):
162162
result=queue.next_n_rows(0)
163163
assertresult.num_rows==0
164164
assertqueue.table_row_index==0
165-
# Instead of comparing tables directly, just check the row count
166-
# This avoids issues with empty table schema differences
167165

168166
@patch("databricks.sql.utils.ThriftCloudFetchQueue._create_next_table")
169167
deftest_next_n_rows_partial_table(self,mock_create_next_table):

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp