Commit53eef60

Jesse Whitehouse

committed

Stop skipping TextTest

The fixes from fixing StringTest also fixed these teststest_suite.py::TextTest_databricks+databricks::test_literal PASSEDtest_suite.py::TextTest_databricks+databricks::test_literal_backslashes PASSEDtest_suite.py::TextTest_databricks+databricks::test_literal_non_ascii PASSEDtest_suite.py::TextTest_databricks+databricks::test_literal_percentsigns PASSEDtest_suite.py::TextTest_databricks+databricks::test_literal_quoting PASSEDtest_suite.py::TextTest_databricks+databricks::test_text_empty_strings PASSEDtest_suite.py::TextTest_databricks+databricks::test_text_null_strings PASSEDtest_suite.py::TextTest_databricks+databricks::test_text_roundtrip PASSEDSigned-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

1 parentaf1a49e commit53eef60Copy full SHA for 53eef60

File tree

1 file changed

-22

lines changed

src/databricks/sqlalchemy/test
- test_suite.py

1 file changed

-22

lines changed

`‎src/databricks/sqlalchemy/test/test_suite.py‎`

Lines changed: 0 additions & 22 deletions

Original file line number	Diff line number	Diff line change
`@@ -237,28 +237,6 @@ def test_row_w_scalar_select(self):`
`237`	`237`
`238`	`238`
`239`	`239`
`240`		`-classTextTest(TextTest):`
`241`		`-"""Fixing StringTest should fix these failures also."""`
`242`		`-`
`243`		`-@pytest.mark.skip(`
`244`		`-reason="String implementation needs work. See comments from StringTest."`
`245`		`- )`
`246`		`-deftest_literal_backslashes(self):`
`247`		`-"""`
`248`		`- Exception:`
`249`		`- AssertionError: assert 'backslash one backslash two\\ end' in ['backslash one\\ backslash two\\\\ end']`
`250`		`- """`
`251`		`-`
`252`		`-@pytest.mark.skip(`
`253`		`-reason="String implementation needs work. See comments from StringTest."`
`254`		`- )`
`255`		`-deftest_literal_quoting(self):`
`256`		`-"""`
`257`		`- Exception:`
`258`		`- assert 'some text hey "hi there" thats text' in ['some\'text\' hey "hi there" that\'s text']`
`259`		`- """`
`260`		`-`
`261`		`-`
`262`	`240`	`classTimeMicrosecondsTest(TimeMicrosecondsTest):`
`263`	`241`	`@pytest.mark.skip(`
`264`	`242`	`reason="Time type implementation needs work. Microseconds are not handled at all."`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit53eef60

File tree

1 file changed

1 file changed

`‎src/databricks/sqlalchemy/test/test_suite.py‎`

0 commit comments