Commit10ab6f8

authored and

committed

Cross version testing

* Bump down the version bound and convert the spark jobs into multi-dbr jobs

1 parentfc62545 commit10ab6f8Copy full SHA for 10ab6f8

File tree

-4

lines changed

cmdexec/clients/python
- src/databricks/sql
  - thrift_backend.py
- tests
  - test_thrift_backend.py

-4

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -284,9 +284,9 @@ def attempt_request(attempt):`
`284`	`284`	`def_check_protocol_version(self,t_open_session_resp):`
`285`	`285`	`protocol_version=t_open_session_resp.serverProtocolVersion`
`286`	`286`
`287`		`-ifprotocol_version<ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V3:`
	`287`	`+ifprotocol_version<ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V2:`
`288`	`288`	`raiseOperationalError("Error: expected server to use a protocol version >= "`
`289`		`-"SPARK_CLI_SERVICE_PROTOCOL_V3, "`
	`289`	`+"SPARK_CLI_SERVICE_PROTOCOL_V2, "`
`290`	`290`	`"instead got: {}".format(protocol_version))`
`291`	`291`
`292`	`292`	`def_check_initial_namespace(self,catalog,schema,response):`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,6 @@ def test_bad_protocol_versions_are_rejected(self, tcli_service_client_cass):`
`108`	`108`	`ttypes.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9,`
`109`	`109`	`ttypes.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10,`
`110`	`110`	`ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V1,`
`111`		`-ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V2,`
`112`	`111`	`]`
`113`	`112`
`114`	`113`	`forprotocol_versioninbad_protocol_versions:`
`@@ -125,8 +124,9 @@ def test_bad_protocol_versions_are_rejected(self, tcli_service_client_cass):`
`125`	`124`	`deftest_okay_protocol_versions_succeed(self,tcli_service_client_cass):`
`126`	`125`	`t_http_client_instance=tcli_service_client_cass.return_value`
`127`	`126`	`good_protocol_versions= [`
	`127`	`+ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V2,`
`128`	`128`	`ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V3,`
`129`		`-ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V4,`
	`129`	`+ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V4`
`130`	`130`	`]`
`131`	`131`
`132`	`132`	`forprotocol_versioningood_protocol_versions:`

Comments

(0)