Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[I2-30] Hamburger Side Menu#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
TR-04 wants to merge5 commits intomaster
base:master
Choose a base branch
Loading
fromI2-30/new-hamburger-menu

Conversation

@TR-04
Copy link
Contributor

  • Used dom portal to render hamburger at document body instead of at nav
    • why is portal needed? Hamburger is added in navbar.tsx, so the blur-grey backdrop only affects the nav. Hence we move the location of the hamburger using a portal so backdrop affects all components
    • why not place hamburger at index.tsx? Our hamburger icon is placed on the navbar, and will follow the navbar around. So, click detection is in navbar.tsx. Our x button is place in hamburger.tsx and thus so is close detection. Our nav handles closing. So we pass props back to nav. But this means we need to redefine every nav with these new props.
  • Quick exit using Esc or tapping outside of sidemenu
  • Scroll bar padding offset added
  • Socials added to bottom of sidemenu

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TR-04

[8]ページ先頭

©2009-2025 Movatter.jp