- Notifications
You must be signed in to change notification settings - Fork1
Jinja#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
makesitgood commentedDec 27, 2014
This looks good so far. When I was trying to build on this previously I got caught up on jinja within html tags, things like That really spidered out places that needed to expect a jinja statement start. You've got a test that should cover the first case, what about the second? If someone does something odd like Is it easy enough to make the error message "Invalid cratejoy syntax at line: " I can't think of a legit reason for that one, but it'd be valid jinja and potentially a pain in the ass to interpret. |
aelaguiz commentedDec 27, 2014
They parse fine, although the jinja in that class isn't actually parsed. My goal isn't really to build the world's best parser but just to catch additional types of errors. I've tested this against all of our merchants themes and it works fine / catches the things I want it to catch. It definitely can miss things, but I'm open to it being improved over time. |