- Notifications
You must be signed in to change notification settings - Fork31
Make datetime.time json serializable, to string ISO format.#701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c77c110 toa4fbe65Comparea4fbe65 to3b00367CompareDocs failing with |
| request.return_value=fake_response(200) | ||
| obj=dt.datetime.now().time() | ||
| client.sql("insert into my_table (str_col) values (?)", (obj,)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not really testing that the time format is correct and understood by CrateDB as it will just take the given string and stores it.
| client.sql("insert into my_table (str_col) values (?)", (obj,)) | |
| client.sql("SELECT ?::TIMETZ AS t_tz", (obj,)) |
Additionally, this would test the decoding of aTIMETZ type.
Summary of the changes / Why this is an improvement
Fixes#696
Checklist