Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.8k
Update factorization.md [Update Powersmooth Definition]#1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
The definition of powersmooth was a bit confusing so I added a formal definition inspired by a number theory book.
Hi, thank you very much for the pull request! I think one other issue here is that the article mistakenly applies the term "powersmooth" to On a side note, I think it's more common to put commas outside of |
t0wbo2t commentedMay 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sure, done. |
Commas are now outside $...$ and definiton is for (p - 1) for consistency.
Thanks! But what I meant is, the article currently uses an incorrect definition of powersmooth, and your initial edit was correct. And I suggested to rewrite other parts of the article to make it clear that the powersmooth number is actually |
Updated materials related to powersmoothness.Corrected some minor mistakes.
I have changed materials to the best of my knowledge. Please let me know if there are any errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the update! I added a few more change suggestions, hopefully after that situation about powersmooth numbers will be completely clarified.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Thanks! |
Thanks to you too. I am studying from cp-algo so I am also thinking of contributing as much as possible. :) |
The definition of powersmooth was a bit confusing so I added a formal definition inspired by a number theory book.