Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update factorization.md [Update Powersmooth Definition]#1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
adamant-pwn merged 7 commits intocp-algorithms:mainfromt0wbo2t:patch-1
May 29, 2025

Conversation

t0wbo2t
Copy link
Contributor

The definition of powersmooth was a bit confusing so I added a formal definition inspired by a number theory book.

The definition of powersmooth was a bit confusing so I added a formal definition inspired by a number theory book.
@adamant-pwn
Copy link
Member

Hi, thank you very much for the pull request!

I think one other issue here is that the article mistakenly applies the term "powersmooth" to$p$, while it should be applied to$p-1$ instead. Would it be okay for you to update this as well, so that it is consistent with the formal definition, and is clear enough what it refers to exactly?

On a side note, I think it's more common to put commas outside of$...$ expressions?

@t0wbo2t
Copy link
ContributorAuthor

t0wbo2t commentedMay 21, 2025
edited
Loading

Sure, done.

Commas are now outside $...$ and definiton is for (p - 1) for consistency.
@adamant-pwn
Copy link
Member

Thanks! But what I meant is, the article currently uses an incorrect definition of powersmooth, and your initial edit was correct. And I suggested to rewrite other parts of the article to make it clear that the powersmooth number is actually$p-1$, and not$p$.

t0wbo2t reacted with thumbs up emoji

Updated materials related to powersmoothness.Corrected some minor mistakes.
@t0wbo2t
Copy link
ContributorAuthor

I have changed materials to the best of my knowledge. Please let me know if there are any errors.

Copy link
Member

@adamant-pwnadamant-pwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the update! I added a few more change suggestions, hopefully after that situation about powersmooth numbers will be completely clarified.

t0wbo2t reacted with heart emoji
t0wbo2tand others added4 commitsMay 29, 2025 11:18
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
@t0wbo2tt0wbo2t requested a review fromadamant-pwnMay 29, 2025 05:56
@adamant-pwn
Copy link
Member

Thanks!

t0wbo2t reacted with hooray emoji

@adamant-pwnadamant-pwn merged commit3491526 intocp-algorithms:mainMay 29, 2025
github-actionsbot added a commit that referenced this pull requestMay 29, 2025
@t0wbo2t
Copy link
ContributorAuthor

Thanks to you too. I am studying from cp-algo so I am also thinking of contributing as much as possible. :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@adamant-pwnadamant-pwnAwaiting requested review from adamant-pwn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@t0wbo2t@adamant-pwn

[8]ページ先頭

©2009-2025 Movatter.jp