Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

On Parallel Binary Search#1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kostca wants to merge15 commits intomain
base:main
Choose a base branch
Loading
frompbs
Open

On Parallel Binary Search#1384

kostca wants to merge15 commits intomainfrompbs

Conversation

@kostca
Copy link
Contributor

No description provided.

@kostcakostca linked an issueOct 27, 2024 that may beclosed by this pull request
@mhayter
Copy link
Contributor

Hello @Kostero and welcome! Thanks for joining the project and thanks for the contribution!

Here's some quick initial feedback:

Consider putting text in online grammar/spell checker. I noticed than 'Specifically' was misspelled.

Also, I'd personally prefer more descriptive variable names rather thanA,X,M, etc. especially considerM is already used in the article for midpoint.

Also, consider compiling the given code.

What isP that is returned?

Also, I think we use snake case for functions and it may make sense to haveleft andright be astruct as they are parallel arrays.

@kostca
Copy link
ContributorAuthor

Thanks for the feedback.

I have fixed some issues. Comments for the remaining ones below.

Also, I'd personally prefer more descriptive variable names rather than A, X, M, etc. especially consider M is already used in the article for midpoint.

A and X are mostly there to keep things simple and to not repeat long variables names (especially in the table explaining what we actually do). I would prefer to keep it that way.

What is P that is returned?

I have a problem of changing the variables over and over, after doing all the checks (including compilation). It should work now. I will try to add tests in the follow-up, just wanted to get the first review asap.

It may make sense to have left and right be a struct as they are parallel arrays.

I kinda disagree here, as they directly refer toint l = -1, r = n; in the prior binary search code (I changed the variable names now to be more consistent), so I would keep them as separate parallel arrays (as they are separate parallel variables in that code).

Copy link
Member

@adamant-pwnadamant-pwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the pull request! I have a few comments that I think should be addressed before this is merged.

|**step 4**| answer in\([3,4)\)| answer in\([5,6)\)| answer in\([1,2)\)| answer in\([2,3)\)|
||\( index = 3\)|\( index = 5\)|\( index = 1\)|\( index = 2\)|

We generally process this table by columns (queries), but notice that in each row we often repeat access to certain values of the array. To limit access to these values, we can process the table by rows (steps). This does not make huge difference in our small example problem (as we can access all elements in $\mathcal{O}(1)$), but in more complex problems, where computing these values is more complicated, this might be essential to solve these problems efficiently. Moreover, note that we can arbitrarily choose the order in which we answer questions in a single row. Let us look at the code implementing this approach.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd really prefer to add a bit more of the following:

  1. Motivation to ever consider doing it in the first place;
  2. Some specific examples onhow using this reduces the complexity.

I think for the latter there are some very simple applications like finding order of key on segment in$O(\log n)$?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PTAL now

@mhayter
Copy link
Contributor

Any update here?

@mhayter
Copy link
Contributor

Is this dead?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@adamant-pwnadamant-pwnAwaiting requested review from adamant-pwn

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parallel Binary Search

4 participants

@kostca@mhayter@adamant-pwn

[8]ページ先頭

©2009-2025 Movatter.jp