Commit08dde3d

committed

refactor(CModal): move the context outside the component

1 parent56e615d commit08dde3dCopy full SHA for 08dde3d

File tree

+23

-23

lines changed

+23

-23

lines changed

Lines changed: 3 additions & 20 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,17 +1,10 @@`
`1`		`-importReact,{`
`2`		`-createContext,`
`3`		`-ElementType,`
`4`		`-forwardRef,`
`5`		`-HTMLAttributes,`
`6`		`-RefObject,`
`7`		`-useEffect,`
`8`		`-useRef,`
`9`		`-useState,`
`10`		`-}from'react'`
	`1`	`+importReact,{ElementType,forwardRef,HTMLAttributes,useEffect,useRef,useState}from'react'`
`11`	`2`	`importPropTypesfrom'prop-types'`
`12`	`3`	`importclassNamesfrom'classnames'`
`13`	`4`	`importtype{Options}from'@popperjs/core'`
`14`	`5`
	`6`	`+import{CDropdownContext}from'./CDropdownContext'`
	`7`	`+`
`15`	`8`	`import{PolymorphicRefForwardingComponent}from'../../helpers'`
`16`	`9`	`import{useForkedRef,usePopper}from'../../hooks'`
`17`	`10`	`import{placementPropType}from'../../props'`
`@@ -169,16 +162,6 @@ export interface CDropdownProps extends HTMLAttributes<HTMLDivElement \| HTMLLIEl`
`169`	`162`	`visible?:boolean`
`170`	`163`	`}`
`171`	`164`
`172`		`-interfaceContextPropsextendsCDropdownProps{`
`173`		`-// eslint-disable-next-line @typescript-eslint/no-explicit-any`
`174`		`-dropdownToggleRef:RefObject<any\|null>`
`175`		`-dropdownMenuRef:RefObject<HTMLDivElement\|HTMLUListElement\|null>`
`176`		`-setVisible:React.Dispatch<React.SetStateAction<boolean\|undefined>>`
`177`		`-portal:boolean`
`178`		`-}`
`179`		`-`
`180`		`-exportconstCDropdownContext=createContext({}asContextProps)`
`181`		`-`
`182`	`165`	`exportconstCDropdown:PolymorphicRefForwardingComponent<'div',CDropdownProps>=forwardRef<`
`183`	`166`	`HTMLDivElement\|HTMLLIElement,`
`184`	`167`	`CDropdownProps`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,18 @@`
	`1`	`+import{createContext,RefObject}from'react'`
	`2`	`+import{Alignments}from'./types'`
	`3`	`+`
	`4`	`+exportinterfaceCDropdownContextProps{`
	`5`	`+alignment?:Alignments`
	`6`	`+container?:DocumentFragment\|Element\|(()=>DocumentFragment\|Element\|null)\|null`
	`7`	`+dark?:boolean`
	`8`	`+// eslint-disable-next-line @typescript-eslint/no-explicit-any`
	`9`	`+dropdownToggleRef:RefObject<any\|null>`
	`10`	`+dropdownMenuRef:RefObject<HTMLDivElement\|HTMLUListElement\|null>`
	`11`	`+setVisible:React.Dispatch<React.SetStateAction<boolean\|undefined>>`
	`12`	`+popper?:boolean`
	`13`	`+portal?:boolean`
	`14`	`+variant?:'btn-group'\|'dropdown'\|'input-group'\|'nav-item'`
	`15`	`+visible?:boolean`
	`16`	`+}`
	`17`	`+`
	`18`	`+exportconstCDropdownContext=createContext({}asCDropdownContextProps)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,8 @@ import React, { ElementType, forwardRef, HTMLAttributes, useContext } from 'reac`
`2`	`2`	`importPropTypesfrom'prop-types'`
`3`	`3`	`importclassNamesfrom'classnames'`
`4`	`4`
`5`		`-import{CDropdownContext}from'./CDropdown'`
`6`	`5`	`import{CConditionalPortal}from'../conditional-portal'`
	`6`	`+import{CDropdownContext}from'./CDropdownContext'`
`7`	`7`
`8`	`8`	`import{PolymorphicRefForwardingComponent}from'../../helpers'`
`9`	`9`	`import{useForkedRef}from'../../hooks'`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,7 @@ import PropTypes from 'prop-types'`
`3`	`3`	`importclassNamesfrom'classnames'`
`4`	`4`
`5`	`5`	`import{CButton,CButtonProps}from'../button/CButton'`
`6`		`-`
`7`		`-import{CDropdownContext}from'./CDropdown'`
	`6`	`+import{CDropdownContext}from'./CDropdownContext'`
`8`	`7`
`9`	`8`	`import{triggerPropType}from'../../props'`
`10`	`9`	`importtype{Triggers}from'../../types'`

Comments

(0)