Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6034a01

Browse files
committed
refactor(html-attr): cleanup
1 parent9c2725b commit6034a01

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

‎projects/coreui-angular/src/lib/shared/html-attr.directive.ts‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import{Directive,ElementRef,Input,OnInit,Renderer2}from'@angular/core';
1+
import{Directive,ElementRef,Input,OnInit,Renderer2}from'@angular/core';
22

33
@Directive({
44
selector:'[cHtmlAttr]',
@@ -7,8 +7,7 @@ import {Directive, ElementRef, Input, OnInit, Renderer2} from '@angular/core';
77
})
88
exportclassHtmlAttributesDirectiveimplementsOnInit{
99

10-
//@ts-ignore
11-
@Input()cHtmlAttr:{[key:string]:any};
10+
@Input()cHtmlAttr?:{[key:string]:any};
1211

1312
constructor(
1413
privaterenderer:Renderer2,
@@ -18,7 +17,7 @@ export class HtmlAttributesDirective implements OnInit {
1817
ngOnInit():void{
1918
constattribs=this.cHtmlAttr;
2019
for(constattrinattribs){
21-
if(attr==='style'&&typeof(attribs[attr])==='object'){
20+
if(attr==='style'&&typeof(attribs[attr])==='object'){
2221
this.setStyle(attribs[attr]);
2322
}elseif(attr==='class'){
2423
this.addClass(attribs[attr]);
@@ -36,16 +35,16 @@ export class HtmlAttributesDirective implements OnInit {
3635
}
3736
}
3837

39-
privateaddClass(classes:string):void{
38+
privateaddClass(classes:string|string[]):void{
4039
constclassArray=(Array.isArray(classes) ?classes :classes.split(' '));
4140
classArray.filter((element)=>element.length>0).forEach(element=>{
42-
this.renderer.addClass(this.el.nativeElement,element);
41+
this.renderer.addClass(this.el.nativeElement,element);
4342
});
4443
}
4544

4645
privatesetAttrib(key:string,value:string|null):void{
4746
value!==null ?
48-
this.renderer.setAttribute(this.el.nativeElement,key,value) :
47+
this.renderer.setAttribute(this.el.nativeElement,key,value) :
4948
this.renderer.removeAttribute(this.el.nativeElement,key);
5049
}
5150
}

‎projects/coreui-icons-angular/src/lib/shared/html-attr.directive.spec.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ import { HtmlAttributesDirective } from './html-attr.directive';
88
template:`
99
<div [cHtmlAttr]="{class: 'test', style: {backgroundColor: 'red'}, id: 'id-1'}"></div>`
1010
})
11-
classTestComponent{
12-
}
11+
classTestComponent{}
1312

1413
describe('HtmlAttributesDirective',()=>{
1514

‎projects/coreui-icons-angular/src/lib/shared/html-attr.directive.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,11 @@ export class HtmlAttributesDirective implements OnInit {
2727
}
2828
}
2929

30-
privatesetStyle(styles:any):void{
31-
// tslint:disable-next-line:forin
30+
privatesetStyle(styles:{[x:string]:any;}):void{
3231
for(conststyleinstyles){
33-
this.renderer.setStyle(this.el.nativeElement,style,styles[style]);
32+
if(style){
33+
this.renderer.setStyle(this.el.nativeElement,style,styles[style]);
34+
}
3435
}
3536
}
3637

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp