- Notifications
You must be signed in to change notification settings - Fork3.2k
Adjust maximum value and description ofcompression.level config to respect zstd specific values#5223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… respect zstd specific values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the configuration forcompression.level to properly support zstd compression levels. The maximum compression level constant is increased from 12 to 22, and the documentation is updated to include the valid range for zstd compression.
Key Changes:
- Updated
RD_KAFKA_COMPLEVEL_MAXconstant from 12 to 22 to accommodate zstd's maximum compression level - Enhanced documentation string to include zstd's valid compression level range [0-22]
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/rdkafka_conf.h | Updated the maximum compression level constant to support zstd |
| src/rdkafka_conf.c | Added zstd compression level range to the configuration property description |
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
🎉 All Contributor License Agreements have been signed. Ready to merge. |
No description provided.