- Notifications
You must be signed in to change notification settings - Fork933
[KIP-848] Tests for changes in DescribeConsumerGroups#1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Tests for theDescribeConsumerGroups API have been updated to handle and verify the newConsumerGroupType field for both classic and consumer protocols, and obsolete skip logic has been removed.
- Added
ConsumerGroupTypeimport and updatedconsume_messagesto accept agroup_protocolparameter. - Expanded
verify_describe_groupsto assertdesc.typefor both classic and consumer group protocols. - Removed the conditional skip for consumer protocol tests.
| 'on_commit':verify_commit_result, | ||
| 'auto.offset.reset':'earliest'} | ||
| ifgroup_protocol=='classic' : |
CopilotAIMay 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Remove the extra space before the colon in the if statement to follow style guidelines (e.g., PEP8).
| ifgroup_protocol=='classic': | |
| ifgroup_protocol=='classic': |
| # Delete group | ||
| perform_admin_operation_sync(admin_client.delete_consumer_groups, [group],request_timeout=10) | ||
| consumer_group='test-group-consumer' |
CopilotAIMay 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[nitpick] The test logic for classic and consumer group protocols is nearly identical; consider refactoring into a parameterized helper or loop to reduce duplication.
| # Delete group | ||
| perform_admin_operation_sync(admin_client.delete_consumer_groups, [group],request_timeout=10) | ||
| consumer_group='test-group-consumer' |
CopilotAIMay 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There are trailing spaces at the end of this line; consider removing them to clean up formatting.
| consumer_group='test-group-consumer' | |
| consumer_group='test-group-consumer' |
c7e0997 tof370a0bCompareAnalysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
Modified test for changes in DescribeConsumerGroups api