- Notifications
You must be signed in to change notification settings - Fork933
Admin client impl fixes#1823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Admin client impl fixes#1823
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ype of TopicPartition
Siobhán Sterrett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let usrecheck it. |
1 similar comment
Siobhán Sterrett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let usrecheck it. |
joaoe commentedSep 30, 2024
I think this might touch some code I changed here But this project is not accepting PRs. It's annoying. |
A handful of minor fixes to cimpl. Probably nothing that will impact real-life use-cases, since these are all buried inside
_AdminClientImpl, but they were bothering me."topic_names"and"future"inkwsarray inAdmin_describe_topics()If a user tried to pass
topic_namesorfutureinto_AdminClientImpl.describe_topics()as keyword arguments, they would end up swapped, which would lead to confusing errors.TypeErrorinAdmin_list_consumer_group_offset()ifrequestis not a listTypeErrorinAdmin_alter_consumer_group_offsets()ifrequestis not a listIn both of these cases, the library would raise
ValueErrorifrequestwas a list with anything other than 1 item... but ifrequestwasn't a list, it would result in an internal error when it tried to access its first item.plistinpy_to_c_parts()to be instances of a subtype ofTopicPartitionIf a user passed a list of instances of a subtype of
TopicPartition, the library would raise aTypeError, even if the instances were otherwise valid.