Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0e3edd3

Browse files
Merge pull request#6 from codewithsathya/feature/refactor-submission
Refactor code
2 parents72f538e +a9c2c38 commit0e3edd3

File tree

6 files changed

+78
-36
lines changed

6 files changed

+78
-36
lines changed

‎.changeset/purple-cows-do.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@leetnotion/leetcode-api":minor
3+
---
4+
5+
Return Submission type instead of RecentSubmission in getting recent submission and also return null if there are no submissions

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name":"@leetnotion/leetcode-api",
3-
"version":"1.5.0",
3+
"version":"1.6.0",
44
"description":"Get user profiles, submissions, and problems on LeetCode.",
55
"type":"module",
66
"types":"lib/index.d.ts",

‎src/_tests/leetcode-advanced.test.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,35 +93,39 @@ describe('LeetCode Advanced', { timeout: 60_000 * 60 }, () => {
9393
'should be able to get recent submission',
9494
async()=>{
9595
constrecentSubmission=awaitlc.recentSubmission();
96+
expect(recentSubmission).not.toBeNull();
9697
expect(recentSubmission).toBeTruthy();
97-
expect(recentSubmission.id.length).toBeGreaterThan(0);
98+
expect(recentSubmission?.id).toBeGreaterThan(0);
9899
},
99100
);
100101

101102
it.skipIf(!process.env['TEST_LEETCODE_SESSION'])(
102103
'should be able to get detailed submission of a user',
103104
async()=>{
104105
constrecentSubmission=awaitlc.recentSubmissionOfUser('jacoblincool');
106+
expect(recentSubmission).not.toBeNull();
105107
expect(recentSubmission).toBeTruthy();
106-
expect(recentSubmission.id.length).toBeGreaterThan(0);
108+
expect(recentSubmission?.id).toBeGreaterThan(0);
107109
},
108110
);
109111

110112
it.skipIf(!process.env['TEST_LEETCODE_SESSION'])(
111113
'should be able to get recent detailed submission',
112114
async()=>{
113115
constrecentSubmission=awaitlc.recentSubmissionDetail();
114-
expect(recentSubmission.code.length).toBeGreaterThan(0);
115-
expect(recentSubmission.id).toBeGreaterThan(0);
116+
expect(recentSubmission).not.toBeNull();
117+
expect(recentSubmission?.code.length).toBeGreaterThan(0);
118+
expect(recentSubmission?.id).toBeGreaterThan(0);
116119
},
117120
);
118121

119122
it.skipIf(!process.env['TEST_LEETCODE_SESSION'])(
120123
'should be able to get recent detailed submission of a user',
121124
async()=>{
122125
constrecentSubmission=awaitlc.recentSubmissionDetailOfUser('jacoblincool');
123-
expect(recentSubmission.code.length).toBeGreaterThan(0);
124-
expect(recentSubmission.id).toBeGreaterThan(0);
126+
expect(recentSubmission).not.toBeNull();
127+
expect(recentSubmission?.code.length).toBeGreaterThan(0);
128+
expect(recentSubmission?.id).toBeGreaterThan(0);
125129
},
126130
);
127131
});

‎src/leetcode-advanced.ts

Lines changed: 38 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@ import {
1414
ProblemFieldDetails,
1515
QueryParams,
1616
RecentSubmission,
17+
Submission,
1718
SubmissionDetail,
1819
}from'./leetcode-types';
1920
importproblemPropertiesfrom'./problem-properties';
21+
import{memoryStringToNumber,runtimeStringToNumber}from'./utils';
2022

2123
exportclassLeetCodeAdvancedextendsLeetCode{
2224
problemProperties=problemProperties;
@@ -97,47 +99,52 @@ export class LeetCodeAdvanced extends LeetCode {
9799
/**
98100
* Get recent submission of current user.
99101
* Need to be authenticated
100-
*@returns RecentSubmission
102+
*@returns Submission
103+
*@returns null if there are no recent submissions
101104
*/
102-
publicasyncrecentSubmission():Promise<RecentSubmission>{
105+
publicasyncrecentSubmission():Promise<Submission|null>{
103106
constwhoami=awaitthis.whoami();
104-
constrecentSubmissions=awaitthis.recent_submissions(whoami.username,1);
105-
returnrecentSubmissions[0];
107+
returnawaitthis.recentSubmissionOfUser(whoami.username);
106108
}
107109

108110
/**
109111
* Get detailed submission of current user.
110112
* Need to be authenticated
111113
*@returns SubmissionDetail
114+
*@returns null if there are no recent submissions
112115
*/
113-
publicasyncrecentSubmissionDetail():Promise<SubmissionDetail>{
116+
publicasyncrecentSubmissionDetail():Promise<SubmissionDetail|null>{
114117
constwhoami=awaitthis.whoami();
115-
constrecentSubmissions=awaitthis.recent_submissions(whoami.username);
116-
constsubmissionId=parseInt(recentSubmissions[0].id);
118+
constrecentSubmission=awaitthis.recentSubmissionOfUser(whoami.username);
119+
if(recentSubmission===null)returnnull;
120+
constsubmissionId=recentSubmission.id;
117121
returnawaitthis.submission(submissionId);
118122
}
119123

120124
/**
121125
* Get recent submission of a user by username
122126
* Need to be authenticated
123127
*@param username
124-
*@returns RecentSubmission
128+
*@returns Submission
129+
*@returns null if there are no recent submissions
125130
*/
126-
publicasyncrecentSubmissionOfUser(username:string):Promise<RecentSubmission>{
127-
constrecent_submissions=awaitthis.recent_submissions(username);
128-
returnrecent_submissions[0];
131+
publicasyncrecentSubmissionOfUser(username:string):Promise<Submission|null>{
132+
constrecentSubmissions=awaitthis.recent_submissions(username,1);
133+
if(recentSubmissions.length==0)returnnull;
134+
returnthis.convertRecentSubmissionToSubmissionType(recentSubmissions[0]);
129135
}
130136

131137
/**
132138
* Get detail submission of a user by username
133139
* Need to be authenticated
134140
*@param username
135141
*@returns SubmissionDetail
142+
*@returns null if there are no recent submissions
136143
*/
137-
publicasyncrecentSubmissionDetailOfUser(username:string):Promise<SubmissionDetail>{
138-
constrecentSubmissions=awaitthis.recent_submissions(username);
139-
constsubmissionId=parseInt(recentSubmissions[0].id);
140-
returnawaitthis.submission(submissionId);
144+
publicasyncrecentSubmissionDetailOfUser(username:string):Promise<SubmissionDetail|null>{
145+
constrecentSubmission=awaitthis.recentSubmissionOfUser(username);
146+
if(recentSubmission===null)returnnull;
147+
returnawaitthis.submission(recentSubmission.id);
141148
}
142149

143150
/**
@@ -238,6 +245,22 @@ export class LeetCodeAdvanced extends LeetCode {
238245
returnproblems;
239246
}
240247

248+
privateconvertRecentSubmissionToSubmissionType(recentSubmission:RecentSubmission):Submission{
249+
return{
250+
id:parseInt(recentSubmission.id,10),
251+
lang:recentSubmission.lang,
252+
time:recentSubmission.time,
253+
timestamp:parseInt(recentSubmission.timestamp,10),
254+
statusDisplay:recentSubmission.statusDisplay,
255+
runtime:runtimeStringToNumber(recentSubmission.runtime),
256+
url:recentSubmission.url,
257+
isPending:recentSubmission.isPending!=='Not Pending',
258+
title:recentSubmission.title,
259+
memory:memoryStringToNumber(recentSubmission.memory),
260+
titleSlug:recentSubmission.titleSlug,
261+
}asSubmission;
262+
}
263+
241264
privatecombineProperties(arr1:DetailedProblem[],arr2:DetailedProblem[]){
242265
constuniquePropertyOfProblem=this.uniquePropertyOfProblemaskeyofDetailedProblem;
243266
constarr1Map=arr1.reduce(

‎src/leetcode-types.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -232,20 +232,6 @@ export interface MatchedUser {
232232
activeBadge:Badge|null;
233233
}
234234

235-
exportinterfaceRecentSubmission{
236-
id:string;
237-
isPending:string;
238-
memory:string;
239-
runtime:string;
240-
time:string;
241-
timestamp:string;
242-
title:string;
243-
titleSlug:string;
244-
statusDisplay:string;
245-
lang:string;
246-
url:string;
247-
}
248-
249235
exportinterfaceUserProfile{
250236
allQuestionsCount:AllQuestionsCount[];
251237
matchedUser:MatchedUser|null;
@@ -364,6 +350,20 @@ export type SubmissionStatus =
364350
|'Compile Error'
365351
|'Runtime Error';
366352

353+
exportinterfaceRecentSubmission{
354+
id:string;
355+
isPending:string;
356+
memory:string;
357+
runtime:string;
358+
time:string;
359+
timestamp:string;
360+
title:string;
361+
titleSlug:string;
362+
statusDisplay:SubmissionStatus;
363+
lang:string;
364+
url:string;
365+
}
366+
367367
exportinterfaceSubmission{
368368
id:number;
369369
lang:string;

‎src/utils.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,13 @@ export function parse_cookie(cookie: string): Record<string, string> {
1414
exportfunctionsleep(ms:number,val:unknown=null):Promise<unknown>{
1515
returnnewPromise((resolve)=>setTimeout(()=>resolve(val),ms));
1616
}
17+
18+
exportfunctionmemoryStringToNumber(memory:string):number{
19+
constlen=memory.length;
20+
returnparseInt(memory.slice(0,len-3),10);
21+
}
22+
23+
exportfunctionruntimeStringToNumber(runtime:string):number{
24+
constlen=runtime.length;
25+
returnparseInt(runtime.slice(0,len-3),10);
26+
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp