- Notifications
You must be signed in to change notification settings - Fork38
dcmade outdoorLiving project work#621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Update feature_request.md
61cc504
Uh oh!
There was an error while loading.Please reload this page.
dcmade outdoorLiving project work#621
61cc504
Uh oh!
There was an error while loading.Please reload this page.
DCO
DCO
There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message.
To avoid having PRs blocked in the future, always includeSigned-off-by: Author Name <authoremail@example.com>
inevery commit message. You can also do this automatically by using the -s flag (i.e.,git commit -s
).
Here is how to fix the problem so that this code can be merged.
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using
--allow-empty
)
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch bychecking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~1 --signoff
- Force push your changes to overwrite the branch:
git push --force-with-lease origin patch-1
Summary
Commit sha:61cc504, Author: DCMADE, Committer: GitHub; The sign-off is missing.