- Notifications
You must be signed in to change notification settings - Fork38
WIP: fix Storybook#587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ShMcK wants to merge3 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletionsweb-app/.babelrc.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| { | ||
| "sourceType": "unambiguous", | ||
| "presets": [ | ||
| [ | ||
| "@babel/preset-env", | ||
| { | ||
| "shippedProposals": true, | ||
| "loose": true | ||
| } | ||
| ], | ||
| "@babel/preset-typescript" | ||
| ], | ||
| "plugins": [ | ||
| "@babel/plugin-transform-shorthand-properties", | ||
| "@babel/plugin-transform-block-scoping", | ||
| [ | ||
| "@babel/plugin-proposal-decorators", | ||
| { | ||
| "legacy": true | ||
| } | ||
| ], | ||
| [ | ||
| "@babel/plugin-proposal-class-properties", | ||
| { | ||
| "loose": true | ||
| } | ||
| ], | ||
| [ | ||
| "@babel/plugin-proposal-private-property-in-object", | ||
| { | ||
| "loose": true | ||
| } | ||
| ], | ||
| [ | ||
| "@babel/plugin-proposal-private-methods", | ||
| { | ||
| "loose": true | ||
| } | ||
| ], | ||
| "@babel/plugin-proposal-export-default-from", | ||
| "@babel/plugin-syntax-dynamic-import", | ||
| [ | ||
| "@babel/plugin-proposal-object-rest-spread", | ||
| { | ||
| "loose": true, | ||
| "useBuiltIns": true | ||
| } | ||
| ], | ||
| "@babel/plugin-transform-classes", | ||
| "@babel/plugin-transform-arrow-functions", | ||
| "@babel/plugin-transform-parameters", | ||
| "@babel/plugin-transform-destructuring", | ||
| "@babel/plugin-transform-spread", | ||
| "@babel/plugin-transform-for-of", | ||
| "babel-plugin-macros", | ||
| "@babel/plugin-proposal-optional-chaining", | ||
| "@babel/plugin-proposal-nullish-coalescing-operator", | ||
| [ | ||
| "babel-plugin-polyfill-corejs3", | ||
| { | ||
| "method": "usage-global", | ||
| "absoluteImports": "core-js", | ||
| "version": "3.21.1" | ||
| } | ||
| ] | ||
| ] | ||
| } |
3 changes: 0 additions & 3 deletionsweb-app/.storybook/addons.ts
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
19 changes: 0 additions & 19 deletionsweb-app/.storybook/config.ts
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
21 changes: 21 additions & 0 deletionsweb-app/.storybook/main.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // import '../src/styles/reset.css' | ||
| // setup acquireVsCodeApi mock | ||
| // @ts-ignore | ||
| global.acquireVsCodeApi = () => ({ | ||
| postMessage(event) { | ||
| console.log('ERROR: VSCode did not load properly in CodeRoad extension', event) | ||
| }, | ||
| }) | ||
| module.exports = { | ||
| core: { | ||
| builder: 'webpack5', | ||
| }, | ||
| stories: ['../stories/Temp.stories.tsx'], | ||
| addons: ['@storybook/addon-actions', '@storybook/addon-knobs', '@storybook/addon-links'], | ||
| babel: async (options) => ({ | ||
| ...options, | ||
| presets: [...options.presets, '@emotion/babel-preset-css-prop', '@babel/preset-react'], | ||
| }), | ||
| } |
25 changes: 7 additions & 18 deletionsweb-app/.storybook/webpack.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -12,27 +12,16 @@ module.exports = ({ config }) => { | ||
| config.module.rules.push({ | ||
| test: /\.(ts|tsx)$/, | ||
| loader: require.resolve('babel-loader'), | ||
| }) | ||
| config.plugins.push(new MiniCssExtractPlugin({ filename: '[name].css' })) | ||
| // config.plugins.push([ | ||
| // 'babel-plugin-import', | ||
| // { | ||
| // libraryName: '@alifd/next', | ||
| // style: true, | ||
| // }, | ||
| // ]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I worry some components may not work without @alifd/next and emotion support. But I may be wrong! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I've updated my branch. I've also enabled the plugin. Seems to be working. | ||
| config.resolve.extensions.push('.ts', '.tsx') | ||
17 changes: 11 additions & 6 deletionsweb-app/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletionsweb-app/stories/Temp.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Button.stories.js|jsx | ||
| import React from 'react' | ||
| const Button = ({ primary, children }) => <button>{children}</button> | ||
| export default { | ||
| /* 👇 The title prop is optional. | ||
| * See https://storybook.js.org/docs/react/configure/overview#configure-story-loading | ||
| * to learn how to generate automatic titles | ||
| */ | ||
| title: 'Button', | ||
| component: Button, | ||
| } | ||
| export const Primary = () => <Button primary>Button</Button> |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.