Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

WIP: fix Storybook#587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ShMcK wants to merge3 commits intomaster
base:master
Choose a base branch
Loading
fromfix/storybook
Open

WIP: fix Storybook#587

ShMcK wants to merge3 commits intomasterfromfix/storybook

Conversation

ShMcK
Copy link
Member

Get Storybook working again.

Signed-off-by: shmckshawn.j.mckay@gmail.com

@ShMcKShMcK mentioned this pull requestMar 23, 2022
@SavvyShah
Copy link
Contributor

I can help you with this. We can have a talk.

Signed-off-by: shmck <shawn.j.mckay@gmail.com>
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
@ShMcK
Copy link
MemberAuthor

@SavvyShah I've sent you an email.

There are some remaining issues with the storybook setup:

  1. I have only enabled a single example story. Others can be added in .storybook/main.ts
  2. the addons in storybook 6 have changed (https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#new-addon-presets).with-knobs is deprecated but heavily used in the project
  3. 'babel-plugin-import' which is used to simplify a component library imports doesn't seem to work with webpack anymore (https://www.npmjs.com/package/babel-plugin-import). It's currently disabled.
  4. There are a number of TS errors in the stories.

@SavvyShah
Copy link
Contributor

Can we use acodemod to convertstoriesOf to CSF?

@SavvyShahSavvyShah mentioned this pull requestSep 30, 2022
@SavvyShah
Copy link
Contributor

SavvyShah commentedSep 30, 2022•
edited
Loading

Hey@ShMcK . Sorry I have been slow in doing this. But I've made a couple of changes and configured an additional story.
I havelinked a PR where I have made changes.
I found that mocking to the global API should be done inpreview.ts.

// libraryName: '@alifd/next',
// style: true,
// },
// ])
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I worry some components may not work without @alifd/next and emotion support. But I may be wrong!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've updated my branch. I've also enabled the plugin. Seems to be working.

@ShMcK
Copy link
MemberAuthor

Thanks@SavvyShah !
There seem to be some yarn.lock conflicts. These can likely be resolved by deleting the yarn.lock file and runningyarn again.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SavvyShahSavvyShahSavvyShah left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ShMcK@SavvyShah
[8]ページ先頭
©2009-2025 Movatter.jp