Commitfc38477

committed

allow vscode commands with reset

Signed-off-by: shmck <shawn.j.mckay@gmail.com>

1 parentd652457 commitfc38477Copy full SHA for fc38477

File tree

+11

-12

lines changed

+11

-12

lines changed

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,12 +30,10 @@ const onRunReset = async (action: ResetAction, context: Context): Promise<void>`
`30`	`30`	`// load timeline until last pass commit`
`31`	`31`	`reset({ branch, hash})`
`32`	`32`
`33`		`-// TODO:@deprecate command in favor of commands`
`34`	`33`	`// if tutorial.config.reset.command, run it`
`35`		`-if(tutorial?.config?.reset?.command){`
`36`		`-hooks.onReset([tutorial?.config?.reset?.command])`
`37`		`-}elseif(tutorial?.config?.reset?.commands){`
`38`		`-hooks.onReset(tutorial?.config?.reset?.commands)`
	`34`	`+constresetActions=tutorial?.config?.reset`
	`35`	`+if(resetActions){`
	`36`	`+hooks.onReset({commands:resetActions?.commands,vscodeCommands:resetActions?.vscodeCommands})`
`39`	`37`	`}`
`40`	`38`	`}`
`41`	`39`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,9 @@ export const onSolutionEnter = async (actions: TT.StepActions): Promise<void> =>`
`38`	`38`	`awaitonRunTest()`
`39`	`39`	`}`
`40`	`40`
`41`		`-exportconstonReset=async(commands:string[]):Promise<void>=>{`
`42`		`-awaitrunCommands(commands)`
	`41`	`+exportconstonReset=async(actions:TT.StepActions):Promise<void>=>{`
	`42`	`+awaitrunCommands(actions?.commands)`
	`43`	`+awaitrunVSCodeCommands(actions?.vscodeCommands)`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`exportconstonError=async(error:Error):Promise<void>=>{`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import*asgitfrom'../../git'`
`2`	`2`
`3`		`-constloadCommits=async(commits:string[]):Promise<void>=>{`
`4`		`-if(commits){`
	`3`	`+constloadCommits=async(commits:string[]=[]):Promise<void>=>{`
	`4`	`+if(commits&&commits.length){`
`5`	`5`	`// load the current list of commits for validation`
`6`	`6`	`for(constcommitofcommits){`
`7`	`7`	`awaitgit.loadCommit(commit)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ const getLastCommitHash = (position: T.Position, tutorial: TT.Tutorial \| null):`
`41`	`41`	`if(!step){`
`42`	`42`	thrownewError(`No step found matching${stepId}`)
`43`	`43`	`}`
`44`		`-constcommits=step.setup.commits`
	`44`	`+constcommits=step.setup?.commits\|\|[]`
`45`	`45`	`if(!commits.length){`
`46`	`46`	thrownewError(`No commits found on step${stepId}`)
`47`	`47`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,8 @@ import { ProgressStatus } from './index'`
`3`	`3`	`exporttypeMaybe<T>=T\|null`
`4`	`4`
`5`	`5`	`exporttypeConfigReset={`
`6`		`-command?:string`
`7`	`6`	`commands?:string[]`
	`7`	`+vscodeCommands?:VSCodeCommand[]`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`exporttypeTutorialConfig={`
`@@ -58,7 +58,7 @@ export type TutorialSummary = {`
`58`	`58`
`59`	`59`	`exporttypeStepActions={`
`60`	`60`	`commands?:string[]`
`61`		`-commits:string[]`
	`61`	`+commits?:string[]`
`62`	`62`	`files?:string[]`
`63`	`63`	`watchers?:string[]`
`64`	`64`	`filter?:string`

Comments

(0)