Commitd1e7fc3

committed

reset watchers on reset

Signed-off-by: shmck <shawn.j.mckay@gmail.com>

1 parentb6501e0 commitd1e7fc3Copy full SHA for d1e7fc3

File tree

+13

-4

lines changed

+13

-4

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -248,3 +248,8 @@ Adds a review page for viewing tutorial content. The review page should be espec`
`248`	`248`	`- Supports commands on reset`
`249`	`249`	`- Supports running vscode commands anywhere that command line commands can be run`
`250`	`250`	`- Admin mode to allow creators to jump between tutorial levels/steps during development`
	`251`	`+`
	`252`	`+### [0.13.1]`
	`253`	`+`
	`254`	`+- Add logo`
	`255`	`+- Fix issue with watcher tests running on reset`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,7 @@`
`1`		`-import*asTfrom'typings'`
`2`	`1`	`import*asTTfrom'typings/tutorial'`
`3`	`2`	`import*asgitfrom'../git'`
`4`	`3`	`importloadCommitsfrom'./utils/loadCommits'`
`5`		`-importloadWatchersfrom'./utils/loadWatchers'`
	`4`	`+import{loadWatchers,resetWatchers}from'./utils/watchers'`
`6`	`5`	`importopenFilesfrom'./utils/openFiles'`
`7`	`6`	`importrunCommandsfrom'./utils/runCommands'`
`8`	`7`	`importrunVSCodeCommandsfrom'./utils/runVSCodeCommands'`
`@@ -39,6 +38,7 @@ export const onSolutionEnter = async (actions: TT.StepActions): Promise<void> =>`
`39`	`38`	`}`
`40`	`39`
`41`	`40`	`exportconstonReset=async(actions:TT.StepActions):Promise<void>=>{`
	`41`	`+awaitresetWatchers()`
`42`	`42`	`awaitrunCommands(actions?.commands)`
`43`	`43`	`awaitrunVSCodeCommands(actions?.vscodeCommands)`
`44`	`44`	`}`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ const disposeWatcher = (watcher: string) => {`
`14`	`14`	`deletewatcherObject[watcher]`
`15`	`15`	`}`
`16`	`16`
`17`		`-constloadWatchers=(watchers:string[]=[]):void=>{`
	`17`	`+exportconstloadWatchers=(watchers:string[]=[]):void=>{`
`18`	`18`	`if(!watchers.length){`
`19`	`19`	`// remove all watchers`
`20`	`20`	`for(constwatcherofObject.keys(watcherObject)){`
`@@ -55,4 +55,8 @@ const loadWatchers = (watchers: string[] = []): void => {`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`
`58`		`-exportdefaultloadWatchers`
	`58`	`+exportconstresetWatchers=():void=>{`
	`59`	`+for(constwatcherofObject.keys(watcherObject)){`
	`60`	`+disposeWatcher(watcher)`
	`61`	`+}`
	`62`	`+}`

Comments

(0)