Commita8d7557

committed

FirebaseObject: fix spacing and add comments

1 parentad75ff6 commita8d7557Copy full SHA for a8d7557

File tree

-3

lines changed

-3

lines changed

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,6 @@ void FirebaseArduino::set(const String& path, const JsonVariant& value) {`
`38`	`38`	`error_ = set.error();`
`39`	`39`	`}`
`40`	`40`
`41`		`-`
`42`	`41`	`FirebaseObjectFirebaseArduino::get(constchar* path) {`
`43`	`42`	`auto get =FirebaseGet(host_, auth_, path, http_.get());`
`44`	`43`	`error_ = get.error();`
`@@ -85,7 +84,6 @@ bool FirebaseArduino::getBool(const char* path) {`
`85`	`84`	`returnFirebaseObject(get.response()).getBool();`
`86`	`85`	`}`
`87`	`86`
`88`		`-`
`89`	`87`	`voidFirebaseArduino::remove(constchar* path) {`
`90`	`88`	`auto remove =FirebaseRemove(host_, auth_, path, http_.get());`
`91`	`89`	`error_ = remove.error();`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`
`17`	`17`	`#include"FirebaseObject.h"`
`18`	`18`
`19`		`-`
`20`	`19`	`FirebaseObject::FirebaseObject(const String& data) : data_{data} {`
`21`	`20`	`json_ = buffer_.parse(&data_[0]);`
`22`	`21`	`// TODO(proppy): find a way to check decoding error, tricky because`
`@@ -64,15 +63,21 @@ JsonVariant FirebaseObject::getJsonVariant(const String& path) {`
`64`	`63`	`Stringkey(path);`
`65`	`64`	`char* start = &key[0];`
`66`	`65`	`char* end = start + key.length();`
	`66`	+// skip first `/`.
`67`	`67`	`if (*start =='/') {`
`68`	`68`	`start++;`
`69`	`69`	`}`
`70`	`70`	`JsonVariant json = json_;`
`71`	`71`	`while (start < end) {`
	`72`	`+// TODO(proppy) split in a separate function.`
`72`	`73`	`char* p = start;`
	`74`	+// advance to next `/`.
`73`	`75`	`while (p && (p !='/')) p++;`
	`76`	+// make `start` a C string.
`74`	`77`	`*p =0;`
	`78`	+// return json variant at `start`.
`75`	`79`	`json = json.asObject().get(start);`
	`80`	`+// advance to next path element.`
`76`	`81`	`start = p +1;`
`77`	`82`	`}`
`78`	`83`	`return json;`

Comments

(0)