Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add helper.ts#71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
averyjennings wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromfeatureBranch
Open
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletionshelper.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
exportfunctionformatString(input:string):string{
returninput.trim().toLowerCase().replace(/\s+/g,'-');
}

exportfunctioncalculateSum(numbers:number[]):number{
returnnumbers.reduce((acc,num)=>acc+num,0);
}

exportfunctionisValidEmail(email:string):boolean{
constemailRegex=/^[^\s@]+@[^\s@]+\.[^\s@]+$/;
returnemailRegex.test(email);
}

exportfunctiondebounce<Textends(...args:any[])=>any>(
func:T,
delay:number
):(...args:Parameters<T>)=>void{
lettimeoutId:NodeJS.Timeout;
return(...args:Parameters<T>)=>{
clearTimeout(timeoutId);
timeoutId=setTimeout(()=>func(...args),delay);
};
}

exportfunctionchunk<T>(array:T[],size:number):T[][]{
constchunks:T[][]=[];
for(leti=0;i<array.length;i+=size){
chunks.push(array.slice(i,i+size));
}
returnchunks;
}
Comment on lines +25 to +31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🛠️ Refactor suggestion

Add input validation for the size parameter.

The chunk implementation is correct, but it lacks validation for thesize parameter. Consider adding validation to handle edge cases wheresize is less than or equal to 0, which could cause infinite loops or unexpected behavior.

 export function chunk<T>(array: T[], size: number): T[][] {+  if (size <= 0) {+    throw new Error('Chunk size must be greater than 0');+  }   const chunks: T[][] = [];   for (let i = 0; i < array.length; i += size) {     chunks.push(array.slice(i, i + size));   }   return chunks; }
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
exportfunctionchunk<T>(array:T[],size:number):T[][]{
constchunks:T[][]=[];
for(leti=0;i<array.length;i+=size){
chunks.push(array.slice(i,i+size));
}
returnchunks;
}
exportfunctionchunk<T>(array:T[],size:number):T[][]{
if(size<=0){
thrownewError('Chunk size must be greater than 0');
}
constchunks:T[][]=[];
for(leti=0;i<array.length;i+=size){
chunks.push(array.slice(i,i+size));
}
returnchunks;
}
🤖 Prompt for AI Agents
In helper.ts around lines 25 to 31, the chunk function lacks validation for thesize parameter, which can cause infinite loops or unexpected behavior if size isless than or equal to 0. Add input validation at the start of the function tocheck if size is a positive integer greater than 0, and throw an error or returnan empty array if the validation fails to prevent invalid usage.

[8]ページ先頭
©2009-2025 Movatter.jp