NotificationsYou must be signed in to change notification settings
Fork0
Star1

Commit7fbf8f2

committed

Removed code smells and followed naming convention

- Local variable names in java must be with the default regular expression ^[a-z][a-zA-Z0-9]*$https://rules.sonarsource.com/java/tag/convention/RSPEC-117- The diamond operator ("<>") should be used when the type of the maps are already definedhttps://rules.sonarsource.com/java/RSPEC-2293- Package names being camel cased is a code smell

1 parent56a527a commit7fbf8f2Copy full SHA for 7fbf8f2

File tree

17 files changed

+27

-27

lines changed

src
- main/java/com
  - caching
    - LFUCache.java
  - ciphers
    - CaesarBruteForce.java
  - conversions
    - HexadecimalToBinary.java
  - datastructures
  - matchings/stablematching
    - GaleShapley.java
- test/java/com
  - datastructures
  - matchings/stablematching
    - GaleShapleyTest.java

17 files changed

+27

-27

lines changed

`‎src/main/java/com/caching/LFUCache.java‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,8 +75,8 @@ public void deleteNode(Node node) {`
`75`	`75`	`publicLFUCache(intcapacity) {`
`76`	`76`	`this.capacity =capacity;`
`77`	`77`	`size =0;`
`78`		`-freq =newTreeMap<Integer,DLL>();`
`79`		`-map =newHashMap<Integer,Node>();`
	`78`	`+freq =newTreeMap<>();`
	`79`	`+map =newHashMap<>();`
`80`	`80`	`System.out.println("LFUCache initialised with capacity: " +capacity);`
`81`	`81`	`}`
`82`	`82`
`@@ -145,8 +145,8 @@ public void put(int key, T value) {`
`145`	`145`	`dll.deleteNode(dll.tail.pre);`
`146`	`146`	`if (dll.len ==0 &&lowest !=1)`
`147`	`147`	`freq.remove(lowest);`
`148`		`-DLLfreq_one =freq.computeIfAbsent(1,k ->newDLL());`
`149`		`-freq_one.addToHead(node);`
	`148`	`+DLLfreqOne =freq.computeIfAbsent(1,k ->newDLL());`
	`149`	`+freqOne.addToHead(node);`
`150`	`150`	`}`
`151`	`151`	`}`
`152`	`152`

`‎src/main/java/com/ciphers/CaesarBruteForce.java‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,25 +5,25 @@ public class CaesarBruteForce {`
`5`	`5`	`/**`
`6`	`6`	`* Recursively Brute forces a parsed encrypted text, trying out all shifting keys from 1-26, printing out all decryption attempts`
`7`	`7`	`* @param message (String) The encrypted text.`
`8`		`- * @paramKey (int) The key used to decrypt the encrypted text and is increment upon a recursive call.`
	`8`	`+ * @paramkey (int) The key used to decrypt the encrypted text and is increment upon a recursive call.`
`9`	`9`	`* @return (String) Concatenated string of all decryption attempts (For unit testing purposes).`
`10`	`10`	`*/`
`11`		`-publicStringdecrypt(Stringmessage,intKey) {`
	`11`	`+publicStringdecrypt(Stringmessage,intkey) {`
`12`	`12`	`finalStringLETTERS ="ABCDEFGHIJKLMNOPQRSTUVWXYZ";`
`13`		`-if (Key >26){System.out.println();returnnull; }`
	`13`	`+if (key >26){System.out.println();returnnull; }`
`14`	`14`
`15`	`15`	`StringBuilderplainText =newStringBuilder();`
`16`	`16`	`for (charcharacter :message.toUpperCase().toCharArray()) {`
`17`	`17`	`intindex =LETTERS.indexOf(character);`
`18`	`18`
`19`	`19`	`if (index != -1) {`
`20`		`-index -=Key;`
	`20`	`+index -=key;`
`21`	`21`	`//Wrap around index value range[1-26]`
`22`	`22`	`if (index <0) {index +=LETTERS.length(); }`
`23`	`23`	`plainText.append(LETTERS.toCharArray()[index]);`
`24`	`24`	`}else {plainText.append(character); }`
`25`	`25`	`}`
`26`		`-System.out.println(String.format("Current Decryption Key %d : %s",Key,plainText));`
`27`		`-returnplainText.append(decrypt(message,Key+1)).toString();`
	`26`	`+System.out.println(String.format("Current Decryption Key %d : %s",key,plainText));`
	`27`	`+returnplainText.append(decrypt(message,key+1)).toString();`
`28`	`28`	`}`
`29`	`29`	`}`