Commit57c1967

committed

Added constant for string literal - code smell

1 parent7fbf8f2 commit57c1967Copy full SHA for 57c1967

File tree

-4

lines changed

-4

lines changed

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,14 +18,15 @@`
`18`	`18`	`*/`
`19`	`19`	`publicclassDisjointSet<T>implementsSerializable {`
`20`	`20`	`privatestaticfinallongserialVersionUID =3134700471905625636L;`
	`21`	`+privatestaticfinalStringelementKey ="element";`
`21`	`22`
`22`		`-privateMap<T,Node<T>>nodeMap =newHashMap<>();`
	`23`	`+privatefinalMap<T,Node<T>>nodeMap =newHashMap<>();`
`23`	`24`
`24`	`25`	`/**`
`25`	`26`	`* Add an element to the disjoint-set forests as a set.`
`26`	`27`	`*/`
`27`	`28`	`publicvoidmakeSet(Telement) {`
`28`		`-checkNotNull(element,"element");`
	`29`	`+checkNotNull(element,elementKey);`
`29`	`30`	`nodeMap.putIfAbsent(element,newNode<>());`
`30`	`31`	`}`
`31`	`32`
`@@ -36,8 +37,8 @@ public void makeSet(T element) {`
`36`	`37`	`* Rank is an upper bound on the height of node.`
`37`	`38`	`*/`
`38`	`39`	`publicvoidunion(Tleft,Tright) {`
`39`		`-checkNotNull(left,"element");`
`40`		`-checkNotNull(right,"element");`
	`40`	`+checkNotNull(left,elementKey);`
	`41`	`+checkNotNull(right,elementKey);`
`41`	`42`
`42`	`43`	`Node<T>leftNode =nodeMap.get(left),`
`43`	`44`	`rightNode =nodeMap.get(right);`

Comments

(0)