- Notifications
You must be signed in to change notification settings - Fork332
Use the same DialOptions for WASM and non-WASM#473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
flimzy wants to merge1 commit intocoder:masterChoose a base branch fromflimzy:wasmOptions
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
30 changes: 0 additions & 30 deletionsdial.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletionsws.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package websocket // import "github.com/coder/websocket" | ||
| import "net/http" | ||
| // DialOptions represents Dial's options. | ||
| // | ||
| // Note that when building for WebAssembly, the following fields are ignored: | ||
| // HTTPClient, HTTPHeader, Host, CompressionMode, CompressionThreshold. | ||
| type DialOptions struct { | ||
| // HTTPClient is used for the connection. | ||
| // Its Transport must return writable bodies for WebSocket handshakes. | ||
| // http.Transport does beginning with Go 1.12. | ||
| HTTPClient *http.Client | ||
| // HTTPHeader specifies the HTTP headers included in the handshake request. | ||
| HTTPHeader http.Header | ||
| // Host optionally overrides the Host HTTP header to send. If empty, the value | ||
| // of URL.Host will be used. | ||
| Host string | ||
| // Subprotocols lists the WebSocket subprotocols to negotiate with the server. | ||
| Subprotocols []string | ||
| // CompressionMode controls the compression mode. | ||
| // Defaults to CompressionDisabled. | ||
| // | ||
| // See docs on CompressionMode for details. | ||
| CompressionMode CompressionMode | ||
| // CompressionThreshold controls the minimum size of a message before compression is applied. | ||
| // | ||
| // Defaults to 512 bytes for CompressionNoContextTakeover and 128 bytes | ||
| // for CompressionContextTakeover. | ||
| CompressionThreshold int | ||
| } |
6 changes: 0 additions & 6 deletionsws_js.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.