Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

WIP bulk refactor - tests, factories, mocks, oh my#541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
jaggederest wants to merge63 commits intomain
base:main
Choose a base branch
Loading
fromjaggederest/refactor_extension
Draft
Show file tree
Hide file tree
Changes fromall commits
Commits
Show all changes
63 commits
Select commitHold shift + click to select a range
7e1bce9
pretest working
jaggederestJun 16, 2025
c693a46
enable vscode-test and bump tsconfig to modern settings
jaggederestJun 16, 2025
240b649
Merge branch 'main' into jaggederest/integration_tests
jaggederestJun 16, 2025
0e58a31
test: fix integration tests to run without Remote SSH extension
jaggederestJun 16, 2025
872b7e8
Merge remote-tracking branch 'origin/jaggederest/integration_tests' i…
jaggederestJun 16, 2025
01c2d80
autocorrect formatting
jaggederestJun 16, 2025
8ddbf26
bump node version to 22
jaggederestJun 16, 2025
9b74df4
fix: configure Vitest to properly exclude VS Code integration tests
jaggederestJun 16, 2025
adec211
whitespace
jaggederestJun 16, 2025
d9b543a
fix: update tsconfig.json and convert pretty-bytes imports to standar…
jaggederestJun 17, 2025
a7afdd6
Remove testmode flag in favor of checking existence of remote ssh ext…
jaggederestJun 17, 2025
3097d8f
remove superfluous async, enable lint rule
jaggederestJun 18, 2025
a2d2bc8
fix: resolve ESLint @typescript-eslint/require-await errors
jaggederestJun 18, 2025
32dfda4
Update configurations and remove pointless Promise.all
jaggederestJun 18, 2025
12b0124
Tweak eslint config to better handle json/md, remove compile-tests sc…
jaggederestJun 18, 2025
cf58040
feat: expand integration tests and add coverage analysis
jaggederestJun 19, 2025
1be94c3
fix: update integration tests to match actual commands
jaggederestJun 19, 2025
67c47e0
feat: switch to VS Code built-in coverage for integration tests
jaggederestJun 19, 2025
62c88f4
feat: add comprehensive integration test framework
jaggederestJun 20, 2025
907347e
feat: implement comprehensive integration tests for CLI, URI handler,…
jaggederestJun 20, 2025
7563580
feat: add comprehensive unit test coverage for all source files
jaggederestJun 20, 2025
379b9ee
fix: resolve all broken unit tests with proper vscode and API mocking
jaggederestJun 20, 2025
f2863b5
feat: enhance api.ts test coverage to 95.52%
jaggederestJun 20, 2025
ced86e9
feat: achieve 48.4% overall test coverage with incremental improvements
jaggederestJun 21, 2025
1dbee30
docs: update TODO.md and CLAUDE.md to reflect test coverage progress
jaggederestJun 21, 2025
6d93e76
test: add unit tests for commands.ts - improved coverage from 28% to …
jaggederestJun 21, 2025
2471b72
test: improve unit test coverage from 48.4% to 60.11%
jaggederestJun 21, 2025
3e38dca
test: improve remote.ts coverage from 32.61% to 49.21%
jaggederestJun 22, 2025
797b656
test: improve test coverage for commands, storage, and workspacesProv…
jaggederestJun 22, 2025
8f150cb
feat: add structured logging foundation with TDD approach
jaggederestJun 22, 2025
07bffb8
docs: update TODO.md with testing synthesis and logging plan
jaggederestJun 22, 2025
fe296b2
feat: integrate logger into Storage class with TDD approach
jaggederestJun 22, 2025
32b4df0
refactor: create type-safe mock builders and clean up api-helper.test.ts
jaggederestJun 22, 2025
bfd4b34
refactor: clean up type casting in test files
jaggederestJun 22, 2025
d4af4ed
fix: update test-helpers to use proper Storage type
jaggederestJun 22, 2025
6c947fe
docs: update TODO.md with test quality improvement progress
jaggederestJun 22, 2025
f8b6dbb
test: add Logger factory and verify backward compatibility
jaggederestJun 22, 2025
a57d676
fix: address ESLint errors in api.test.ts
jaggederestJun 22, 2025
97ff5fb
docs: simplify TODO.md and update progress
jaggederestJun 22, 2025
8021706
docs: update CLAUDE.md with TDD patterns and techniques from session
jaggederestJun 22, 2025
b624614
feat: integrate Logger into remote.ts with TDD approach
jaggederestJun 22, 2025
2629397
feat: integrate Logger into extension.ts with initialization
jaggederestJun 22, 2025
53272c1
test: add Logger integration tests for headers.ts
jaggederestJun 22, 2025
92c548a
test: add Logger integration tests for workspaceMonitor
jaggederestJun 22, 2025
9e8ed6d
test: add Logger integration tests for inbox
jaggederestJun 22, 2025
3595bda
docs: update TODO.md with Logger integration progress
jaggederestJun 22, 2025
9aac82d
test: add Logger integration tests for error.ts
jaggederestJun 22, 2025
341cc67
test: add Logger integration tests for workspacesProvider
jaggederestJun 23, 2025
dfd55e1
test: add Logger integration tests for commands.ts
jaggederestJun 23, 2025
6285043
docs: mark Logger integration as complete in TODO.md
jaggederestJun 23, 2025
eca919f
refactor: extract helper functions from monolithic activate() in exte…
jaggederestJun 23, 2025
8505c4f
refactor: complete TDD extraction of all functions from activate()
jaggederestJun 23, 2025
8b8edc7
test: consolidate test mocks into reusable factories
jaggederestJun 23, 2025
1a43dd3
docs: update TODO.md and CLAUDE.md with test improvements
jaggederestJun 23, 2025
a1af9cb
test: improve integration tests from 86 to 100 passing
jaggederestJun 23, 2025
eaee610
test: clean up pointless integration tests and enable 3 more
jaggederestJun 23, 2025
c4a2156
test: remove 9 more pointless integration tests
jaggederestJun 23, 2025
1a9f34f
test: remove all skipped integration tests for fresh start
jaggederestJun 24, 2025
6291f7f
refactor: improve testability through dependency injection and test s…
jaggederestJun 26, 2025
a72e943
test: remove flaky UI tests and improve test stability
jaggederestJun 26, 2025
eb787f8
test: simplify test files and reduce verbosity
jaggederestJun 27, 2025
fa1f576
test: reduce test verbosity by 41% while maintaining 84% coverage
jaggederestJun 27, 2025
c73c742
test: simplify test suite by removing low-value tests
jaggederestJun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added.DS_Store
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions.eslintignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
vitest.config.ts
15 changes: 14 additions & 1 deletion.eslintrc.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,8 @@
"parser":"@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion":6,
"sourceType":"module"
"sourceType":"module",
"project":"./tsconfig.json"
},
"plugins": ["@typescript-eslint","prettier"],
"extends": [
Expand All@@ -15,6 +16,18 @@
"prettier"
],
"overrides": [
{
"files": ["*.ts"],
"rules": {
"require-await":"off",
"@typescript-eslint/require-await":"error"
}
},
{
"extends": ["plugin:package-json/legacy-recommended"],
"files": ["*.json"],
"parser":"jsonc-eslint-parser"
},
{
"files": ["*.md"],
"parser":"markdown-eslint-parser"
Expand Down
4 changes: 2 additions & 2 deletions.github/workflows/ci.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ jobs:

-uses:actions/setup-node@v4
with:
node-version:"18"
node-version:"22"

-run:yarn

Expand All@@ -36,7 +36,7 @@ jobs:

-uses:actions/setup-node@v4
with:
node-version:"18"
node-version:"22"

-run:yarn

Expand Down
2 changes: 1 addition & 1 deletion.github/workflows/release.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: "18"
node-version: "22"

- run: yarn

Expand Down
12 changes: 12 additions & 0 deletions.vscode-test.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { defineConfig } from "@vscode/test-cli";

export default defineConfig({
files: "out/test/**/*.test.js",
extensionDevelopmentPath: ".",
extensionTestsPath: "./out/test",
launchArgs: ["--enable-proposed-api", "coder.coder-remote"],
mocha: {
ui: "tdd",
timeout: 20000,
},
});
2 changes: 1 addition & 1 deletion.vscodeignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,4 +12,4 @@ node_modules/**
**/.editorconfig
**/*.map
**/*.ts
*.gif
*.gif
52 changes: 28 additions & 24 deletionsCLAUDE.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,30 @@
# Coder Extension Development Guidelines

## Build and Test Commands

- Build: `yarn build`
- Watch mode: `yarn watch`
- Package: `yarn package`
- Lint: `yarn lint`
- Lint with auto-fix: `yarn lint:fix`
- Run all tests: `yarn test`
- Run specific test: `vitest ./src/filename.test.ts`
- CI test mode: `yarn test:ci`

## Code Style Guidelines

- TypeScript with strict typing
- No semicolons (see `.prettierrc`)
- Trailing commas for all multi-line lists
- 120 character line width
- Use ES6 features (arrow functions, destructuring, etc.)
- Use `const` by default; `let` only when necessary
- Prefix unused variables with underscore (e.g., `_unused`)
- Sort imports alphabetically in groups: external → parent → sibling
- Error handling: wrap and type errors appropriately
- Use async/await for promises, avoid explicit Promise construction where possible
- Test files must be named `*.test.ts` and use Vitest
## Core Philosophy

**First-Principles + KISS**: Question every assumption aggressively, then build the simplest solution from fundamental truths. If there's a straight line, take it, otherwise ask questions and gather any information necessary to determine the right path forward.

## Commands

```bash
yarn lint:fix # Lint with auto-fix
yarn test:ci --coverage # Run ALL unit tests (ALWAYS use this)
yarn pretest && yarn test:integration # Integration tests
```

## Key Rules

- **TypeScript strict mode**, no semicolons, 120 char lines
- **Test files**: `*.test.ts` (Vitest for unit, VS Code API for integration)
- **Use test-helpers.ts**: 30+ mock factories available - NEVER create inline mocks, instead create a new factory in that file and import it
- **TDD always**: Write test → implement → refactor
- **Never use any**: Always try to use at least a decently close Partial type or equivalent
- **Never delete tests**: Only delete or skip tests if directly asked, otherwise ask the user for help if fixing the tests does not work.

## Testing Approach

1. Use `yarn test:ci --coverage` before and after EVERY change
2. Import factories and mocks from test-helpers.ts (createMock* and *Factory)
3. Write a test, make sure it fails, and only then make it pass
4. Use proper types, NEVER use eslint-disable to make mocks work
5. If mocking is too complicated, consider whether the function under test needs a minor refactoring that passes existing tests first, to make it easier to test.
49 changes: 49 additions & 0 deletionsCOVERAGE.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
# Test Coverage Impact Analysis

Baseline coverage: 83.78%

## Test File Impact

| Test File | Coverage Without File | Coverage Delta | Impact |
| -------------------------- | --------------------- | -------------- | -------- |
| api-helper.test.ts | 83.28% | -0.50% | Low |
| api.test.ts | 78.59% | -5.19% | High |
| cliManager.test.ts | 81.58% | -2.20% | Medium |
| commands.test.ts | 88.12% | +4.34% | Negative |
| error.test.ts | 81.53% | -2.25% | Medium |
| extension.test.ts | 82.75% | -1.03% | Low |
| featureSet.test.ts | 83.66% | -0.12% | Minimal |
| headers.test.ts | 82.06% | -1.72% | Low |
| inbox.test.ts | 83.69% | -0.09% | Minimal |
| logger.test.ts | 83.08% | -0.70% | Low |
| proxy.test.ts | 82.10% | -1.68% | Low |
| sshConfig.test.ts | 82.94% | -0.84% | Low |
| sshSupport.test.ts | 83.44% | -0.34% | Minimal |
| storage.test.ts | 85.80% | +2.02% | Negative |
| util.test.ts | 82.12% | -1.66% | Low |
| workspaceMonitor.test.ts | 83.34% | -0.44% | Low |
| workspacesProvider.test.ts | 83.92% | +0.14% | Negative |

## Summary

### High Impact Files (>2% coverage drop):

- **api.test.ts**: -5.19% (critical for API coverage)
- **error.test.ts**: -2.25%
- **cliManager.test.ts**: -2.20%

### Negative Impact Files (coverage increases without them):

- **commands.test.ts**: +4.34% (commands.ts has low coverage at 62.61%)
- **storage.test.ts**: +2.02% (storage.ts has low coverage at 71.01%)
- **workspacesProvider.test.ts**: +0.14%

### Low Impact Files (<2% coverage drop):

- Most other test files have minimal impact on overall coverage

### Recommendations:

1. Keep all High Impact files
2. Consider removing or significantly reducing tests in Negative Impact files
3. Low Impact files are candidates for test reduction based on test quality/value
49 changes: 49 additions & 0 deletionsTODO.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
# VSCode Coder Extension - Remaining Work

## Current Status

- **405 unit tests** (78.49% coverage)
- **69 integration tests** passing
- **1 file** <50% coverage (remote.ts)

## Major Initiatives

### 1. Refactor Monolithic Methods

- [ ] **remote.ts** (49.51% → 80%+) - Break down 366-line setup() method
- [ ] **commands.ts** (68.03% → 80%+) - Create UI abstraction layer

### 2. Connection Reliability

- [ ] Implement exponential backoff for retries
- [ ] Add connection health monitoring
- [ ] Create API/CLI abstraction layer
- [ ] Migrate to CLI-first approach

### 3. Enable Integration Tests (84 remaining)

- [ ] Authentication (24 tests)
- [ ] Workspace Operations (23 tests)
- [ ] Tree Views (21 tests)
- [ ] Remote Connection (36 tests)

### 4. Test Infrastructure

- [ ] Add SSH/Process/FileSystem mocks to test-helpers
- [ ] Create integration test helpers
- [ ] Implement testing patterns (State Machine, Command)

## Success Metrics

| Metric | Current | Target |
| ------------------- | ------- | ------ |
| Unit coverage | 78.49% | 85%+ |
| Integration tests | 69 | 150+ |
| Avg method length | >100 | <50 |
| Files <50% coverage | 1 | 0 |

## Next Steps

1. Extract methods from remote.ts using TDD
2. Create UIProvider interface for commands.ts
3. Enable first batch of integration tests
Loading
[8]ページ先頭
©2009-2025 Movatter.jp