- Notifications
You must be signed in to change notification settings - Fork24
fix: handle agent parameter in URIs#538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| @@ -628,7 +628,7 @@ export class Commands { | |||
| const workspaceOwner = args[0] as string; | |||
| const workspaceName = args[1] as string; | |||
| const workspaceAgent =undefined; //args[2]is reserved, but we do not support multiple agents yet. | |||
| const workspaceAgent = args[2]as string; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
openDevcontainer URIs must include the agent name to work properly, I believe, so this isstring and notstring | undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks for fixing this!
| # git config blame.ignoreRevsFile .git-blame-ignore-revs | ||
| # chore: simplify prettier config (#528) | ||
| f785902f3ad20d54344cc1107285c2a66299c7f6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What's the purpose of this?
ethanndicksonJun 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We have the same file oncoder/coder - it's just a convenient way to remove a formatting commit fromgit blame results. I noticed every line was blamed on#528. No longer the case after runninggit config blame.ignoreRevsFile .git-blame-ignore-revs
ethanndickson commentedJun 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
9d80d67 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This fixes a bug where the
agentquery parameter on the extension URI was ignored.We were previously doing:
where
args[2]was the agent name, but we were discarding it:The same was true for the
coder.opencommand. Presumably due to the comment saying multiple agents aren't supported, which hasn't been true for years.