coder/vscode-coderPublic

NotificationsYou must be signed in to change notification settings
Fork24
Star89

Add package scripts and cli library, enable integration testing#536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

jaggederest wants to merge15 commits intomain

base:main

Choose a base branch

fromjaggederest/integration_tests

Open

Add package scripts and cli library, enable integration testing#536

jaggederest wants to merge15 commits intomainfromjaggederest/integration_tests

+763 −137

Conversation

Copy link

jaggederest commentedJun 16, 2025•
edited
Loading

A working vscode-test integration test that validates that the module will load and add commands, at least.

jaggederest added2 commits

June 16, 2025 12:07

pretest working

7e1bce9

enable vscode-test and bump tsconfig to modern settings

c693a46

jaggederest requested review fromcode-asher andCopilot

June 16, 2025 19:13

Merge branch 'main' into jaggederest/integration_tests

240b649

This comment was marked as outdated.

jaggederestand others added5 commits

June 16, 2025 14:31

test: fix integration tests to run without Remote SSH extension

0e58a31

- Add test mode detection to bypass Remote SSH extension requirement- Skip remoteAuthority access in test mode to avoid API proposal errors- Update test expectations to match actual extension behavior- Configure vscode-test to enable proposed API for tests- Add proper command registration verification with timing delayThe extension now gracefully handles test environments where the RemoteSSH extension is not available, allowing integration tests to pass.🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>

Merge remote-tracking branch 'origin/jaggederest/integration_tests' i…

872b7e8

…nto jaggederest/integration_tests

autocorrect formatting

01c2d80

bump node version to 22

8ddbf26

fix: configure Vitest to properly exclude VS Code integration tests

9b74df4

- Add vitest.config.ts with proper include/exclude patterns- Exclude src/test/** directory from unit tests (VS Code integration tests)- Exclude compiled out/** directory from test discovery- Update tsconfig.json to exclude vitest.config.ts from compilation- Add .eslintignore to skip linting vitest config- Update test script to use default Vitest behavior- Fix .vscodeignore formatting (add missing newline)🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>

jaggederest marked this pull request as ready for review

June 16, 2025 22:05

aslilac reviewed

Jun 16, 2025

View reviewed changes

.eslintignore OutdatedShow resolvedHide resolved

whitespace

adec211

code-asher reviewed

Jun 16, 2025

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Leaving off an approve until we sortprettyBytes but this is great!

src/extension.ts OutdatedShow resolvedHide resolved

src/remote.ts OutdatedShow resolvedHide resolved

src/test/extension.test.tsShow resolvedHide resolved

jaggederestand others added2 commits

June 17, 2025 12:37

fix: update tsconfig.json and convert pretty-bytes imports to standar…

d9b543a

…d ES6- Updated tsconfig.json to use CommonJS module system with proper ES module interop- Converted dynamic imports of pretty-bytes to standard ES6 imports in remote.ts and storage.ts- Added integration test command to CLAUDE.md documentation🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>

Remove testmode flag in favor of checking existence of remote ssh ext…

a7afdd6

…ension and warning user

jaggederest requested review fromaslilac,code-asher andCopilot

June 17, 2025 20:12

CopilotAI reviewed

Jun 17, 2025

View reviewed changes

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds package scripts and a CLI library while enabling integration testing for the extension.

Introduces vitest configuration and integration tests to validate extension activation and command registration.
Updates error handling in the extension activation flow and adjusts asynchronous handling in the remote module.
Enhances package.json scripts and CI/CD configurations for Node 22 support.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
vitest.config.ts	Adds testing configuration for the vitest environment.
src/test/extension.test.ts	Implements integration tests for verifying extension functionality.
src/remote.ts	Modifies async handling in the updateStatus function.
src/extension.ts	Adjusts activation flow and Remote SSH error handling behavior.
package.json	Adds new CLI/test scripts and updates dependency versions.
CLAUDE.md	Documents the new integration test command.
.vscode-test.mjs	Introduces VS Code test configuration via the test-cli package.
.github/workflows/*.yaml	Updates Node version from 18 to 22 in CI and release workflows.
.eslintignore	Excludes vitest.config.ts from linting.

Comments suppressed due to low confidence (2)

src/extension.ts:34

The removal of a thrown error for a missing Remote SSH extension changes the activation behavior. Ensure this fallback is intentional and well-documented so that downstream logic is not unexpectedly executed without the necessary extension.

vscode.window.showErrorMessage(

.vscode-test.mjs:1

[nitpick] Consider adding a comment to explain the purpose of this VS Code test configuration to improve maintainability.

import { defineConfig } from "@vscode/test-cli";

src/extension.ts

Comment on lines +40 to 47

		// eslint-disable-next-line @typescript-eslint/no-explicit-any
		vscodeProposed = (module as any)._load(
		"vscode",
		{
		filename: remoteSSHExtension.extensionPath,
		},
		false,
		);

Copy link

Preview

CopilotAIJun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Using 'module as any' bypasses type safety; consider a more type-safe approach or adding documentation to justify this workaround.

Copilot uses AI. Check for mistakes.

Copy link

Author

jaggederestJun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah I get it buddy I don't like it either but we're polymorphic on the SSH extensions.

code-asher reviewed

Jun 18, 2025

View reviewed changes

src/extension.tsShow resolvedHide resolved

src/remote.ts OutdatedShow resolvedHide resolved

tsconfig.json OutdatedShow resolvedHide resolved

tsconfig.jsonShow resolvedHide resolved

jaggederest mentioned this pull request

Jun 18, 2025

Suggest to user which SSH extension they need to install if missing#537

Open

jaggederestand others added2 commits

June 17, 2025 18:10

remove superfluous async, enable lint rule

3097d8f

fix: resolve ESLint @typescript-eslint/require-await errors

a2d2bc8

- Add parserOptions.project to enable type-aware linting- Disable @typescript-eslint/require-await rule for markdown files- Remove unnecessary async keywords from functions without await🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>

aslilac reviewed

Jun 18, 2025

View reviewed changes

package.json OutdatedShow resolvedHide resolved

src/workspacesProvider.ts OutdatedShow resolvedHide resolved

tsconfig.json OutdatedShow resolvedHide resolved

tsconfig.jsonShow resolvedHide resolved

.eslintrc.json OutdatedShow resolvedHide resolved

Update configurations and remove pointless Promise.all

32dfda4

code-asher approved these changes

Jun 18, 2025

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! Good call on the async rule. If there is an easy way to configure it more cleanly that would be awesome, otherwise maybe we could opt to split linting and formatting at some point.

Tweak eslint config to better handle json/md, remove compile-tests sc…

12b0124

…ript

Labels

None yet

3 participants

Movatterモバイル変換

Add package scripts and cli library, enable integration testing#536

Are you sure you want to change the base?

Add package scripts and cli library, enable integration testing#536

Conversation

jaggederest commentedJun 16, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

code-asher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

CopilotAIJun 17, 2025

Choose a reason for hiding this comment

Uh oh!

jaggederestJun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

code-asher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jaggederest commentedJun 16, 2025•
edited
Loading