- Notifications
You must be signed in to change notification settings - Fork24
[WIP] Progress towards unit test coverage#533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
jaggederest wants to merge14 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+6,773 −426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Add tests for needToken() function covering all TLS configuration scenarios- Add tests for createHttpAgent() including TLS, proxy, and insecure mode- Add tests for startWorkspaceIfStoppedOrFailed() with process spawn mocking- Refactor api.ts to eliminate config access duplication with getConfigString/getConfigPath helpers- Total test count increased from 59 to 82 tests🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Add comprehensive tests for makeCoderSdk, createStreamingFetchAdapter, and waitForBuild- Refactor stream event handlers into testable setupStreamHandlers function- Set up code coverage analysis with vitest and @vitest/coverage-v8- Add coverage commands: yarn test:coverage and yarn test:coverage:ui- Update test count from 59 to 105 tests (102 -> 105 with new handler tests)- Achieve 100% line coverage, 100% function coverage for api.ts- Update CLAUDE.md to always use CI test mode and document coverage commands- Configure vitest.config.ts with coverage thresholds and reporting🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Add 32 tests covering all functions in api-helper.ts- Test errToStr() with Error instances, API errors, ErrorEvent, strings, and edge cases- Test extractAgents() and extractAllAgents() with various workspace configurations- Validate Zod schemas for AgentMetadataEvent- Update CLAUDE.md to reflect standard test running approach- All 137 tests now passing🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Create 12 tests covering Commands class methods- Test workspace operations (openFromSidebar, open, openDevContainer)- Test basic functionality (login, logout, viewLogs)- Test error handling scenarios- Improve commands.ts coverage from ~30% to 56.01%- All 149 tests now passing across the test suite🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Refactor complex inline logic into testable helper functions: - handleRemoteAuthority(): Remote SSH setup and authentication - handleRemoteSetupError(): Comprehensive error handling (CertificateError, AxiosError, generic) - handleUnexpectedAuthResponse(): Unexpected authentication response handling- Add 26 comprehensive tests covering: - Extension activation and command registration - URI handler for vscode:// protocol - Remote authority setup and error scenarios - Authentication flow and context management - Helper function edge cases and error paths- Improve extension.ts coverage: 79.69% → 93.44% (+13.75 percentage points)- Total test suite: 165 → 175 tests (+10 tests)- Overall coverage: 39.01% → 40.35% (+1.34 percentage points)- Update TODO.md with current priority assessment🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Added 55 tests covering all major storage functionality- Tests for URL and session token management- Tests for file system operations and binary downloads- Tests for CLI configuration and path methods- Mock setup for VSCode APIs, file system, and external dependencies- Achieved 89.19% line coverage and 95.65% function coverage🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Added 22 tests covering WorkspaceProvider core functionality- Tests for workspace fetching, tree view, and state management- Tests for WorkspaceTreeItem construction and properties- Mock setup for VSCode TreeView API and EventSource- 18 tests passing, 4 tests need minor mocking fixes- Updated TODO.md to reflect completion of high-priority files🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Refactor WorkspaceProvider to extract testable helper methods: - createEventEmitter() for event emitter creation - handleVisibilityChange() for visibility state management - updateAgentWatchers() for agent watcher management - createAgentWatcher() for individual agent watcher creation - createWorkspaceTreeItem() for workspace tree item creation - getWorkspaceChildren() and getAgentChildren() for tree navigation- Create TestableWorkspaceProvider class extending WorkspaceProvider: - Expose protected methods for testing - Add helper methods for private property access - Avoid infinite recursion issues with property getters/setters- Fix test setup and assertions: - Mock handleVisibilityChange to prevent automatic fetching - Update property access to use helper methods - Properly isolate test scenariosAll 27 workspacesProvider tests now pass (previously 21 failing)Total test suite: 257 tests passing across 13 files🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Consolidate testing achievements: 13/17 files completed (76% done)- Reorganize into clear current status vs remaining work sections- Add comprehensive table showing all 257 tests across 13 test files- Prioritize remaining work: src/remote.ts (high) vs 3 utility files (low)- Define 3-phase approach: completion → quality → infrastructure- Highlight recent workspacesProvider test fixes and achievements- Focus on actionable next steps rather than historical detailsCurrent state: 257 tests passing, robust test infrastructure establishedNext priority: src/remote.ts for SSH and workspace lifecycle testing🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
Refactor remote.ts by extracting 5 testable helper methods:- validateCredentials() - handles login flow and credential validation- createWorkspaceClient() - creates workspace REST client- setupBinary() - handles binary path setup for prod/dev modes- validateServerVersion() - checks server compatibility and features- fetchWorkspace() - fetches workspace with comprehensive error handlingAdd remote.test.ts with 17 comprehensive test cases covering:- Constructor and instance creation- Credential validation and login prompts- Binary setup for production and development modes- Server version validation and incompatibility handling- Workspace fetching with 404/401 error scenarios- Remote window management (close/reload operations)Benefits:- Improved code maintainability through method extraction- Reduced complexity in main setup() method- Comprehensive error scenario testing- Memory-efficient testing approach vs extensive mocking- Maintains all existing functionality while enabling better testingTotal test coverage: 274 tests across 14 files (14/17 source files = 82%)🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Add 38 test cases covering all proxy resolution functionality- Test basic proxy resolution, protocol-specific handling, npm config- Test proxy URL normalization and NO_PROXY bypass logic- Test environment variable handling (case-insensitive)- Test default ports, IPv6 addresses, and edge cases- Achieve comprehensive coverage without memory issues🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Add 14 test cases for inbox.ts covering WebSocket connection, event handling, and disposal- Add 19 test cases for workspaceMonitor.ts covering SSE monitoring, notifications, and status bar updates- Test WebSocket setup with proper URL construction and authentication headers- Test EventSource setup for workspace monitoring with data/error event handling- Test notification logic for autostop, deletion, outdated workspace, and non-running states- Test status bar updates and context management- Test proper cleanup and disposal patterns- Achieve comprehensive coverage for message handling and workspace monitoring functionality🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Complete rewrite based on actual coverage results (70.43% overall)- Document 4 files at 100% coverage: api-helper, api, inbox, proxy- Identify critical gaps: remote.ts (25.4%), commands.ts (56%), workspacesProvider.ts (65%)- Provide prioritized roadmap for achieving 90% overall coverage- Establish clear success metrics and next steps- 345 tests passing across 17 test files (complete test infrastructure)🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR introduces refactoring and additional test coverage across multiple files while extracting helper functions to improve testability. Key changes include new functions in remote.ts for credential validation and client setup, refined tree item and event emitter handling in workspacesProvider.ts, and expansion of test suites for proxy, inbox, commands, and API functionality.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Added detailed coverage and test configuration options |
| src/workspacesProvider.ts | Refactored event emitter and tree item functions; added testability helpers |
| src/remote.ts | Extracted helper functions for credential validation and client setup |
| src/proxy.test.ts | Expanded tests for proxy URL normalization and environment resolution |
| src/inbox.test.ts | Added comprehensive mocks and tests for websocket behavior |
| src/extension.ts | Extracted remote authority handling and error handling functions |
| src/commands.test.ts | Expanded tests covering command execution and user interactions |
| src/api.ts | Introduced helper functions for configuration and stream handling |
| package.json | Updated scripts for test coverage and UI reporting |
| TODO.md | Updated roadmap with detailed coverage targets and next steps |
| CLAUDE.md | Revised test instructions and commands |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the AI slop generation but I didn't want to manually go through all the files. Once I build out a complete test suite then I can go back and do some heavy lifting manually.