Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: handle windows specific paths in log-path parameter#512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 1 commit intomainfrommike/430-vs-code-win-path
Jun 23, 2025

Conversation

ibetitsmike
Copy link
Contributor

@ibetitsmikeibetitsmike commentedMay 22, 2025
edited
Loading

Fixes:#430

@ibetitsmikeibetitsmikeforce-pushed themike/430-vs-code-win-path branch from44e3dfa toab2f929CompareJune 10, 2025 16:28
@bcpeinhardt
Copy link
Collaborator

bcpeinhardt commentedJun 10, 2025
edited
Loading

I suspect the issue was that claude nuked your lockfile (it likes to do that). Just reverting the lockfile fixed the build. I'll leave passing the test and lint checks up to you :)

@ibetitsmikeibetitsmikeforce-pushed themike/430-vs-code-win-path branch frombdc35ba to281fe1aCompareJune 17, 2025 17:28
@ibetitsmikeibetitsmikeforce-pushed themike/430-vs-code-win-path branch from281fe1a tobd9d1caCompareJune 17, 2025 17:47
Copy link
Contributor

@jaggederestjaggederest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems fine to me, but I am not yet competent to hand out the ✅ of approval so I've asked Asher to take a look 👍

@code-asher
Copy link
Member

code-asher commentedJun 20, 2025
edited
Loading

It seems like a reasonable change to me since we already useescapeCommandArg() on other path arguments. It would be nice to see a test forupdateSSHConfig().

The issue says we are printing--log-dir C%3A%5CUsers%5Cmicha%5Clogs, so I assume now we will be printing--log-dir "C%3A%5CUsers%5Cmicha%5Clogs" which might work (or at least not error), but it seems like we should really be printing--log-dir "C:\Users\micha\logs".

Do we know where the escaped chars came from?

@code-asher
Copy link
Member

Oh duh it was usingescape before. Looks good to me. I do think we should test this stuff eventually.

@code-asher
Copy link
Member

code-asher commentedJun 20, 2025
edited
Loading

I know what happened,escapeCommandArg used to be calledescape and was local toupdateSSHConfig, thenformatLogArg was broken out into its own function, with no access to the localescape, butescape happens to be a built-in function so no errors were thrown lol

@ibetitsmike
Copy link
ContributorAuthor

Oh duh it was usingescape before. Looks good to me. I do think we should test this stuff eventually.

@code-asher as in 'unit test'?

@code-asher
Copy link
Member

Unit test would be ideal yeah! But I thinkupdateSSHConfig() would need to be broken out ofRemote. Might not be worth the effort right now, feel free to merge.

@mtojekmtojek merged commitd1289c6 intomainJun 23, 2025
4 checks passed
@mtojekmtojek deleted the mike/430-vs-code-win-path branchJune 23, 2025 11:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jaggederestjaggederestjaggederest left review comments

@matifalimatifalimatifali left review comments

@code-ashercode-ashercode-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy log directory doesn't handle Windows style \
6 participants
@ibetitsmike@bcpeinhardt@code-asher@jaggederest@matifali@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp