- Notifications
You must be signed in to change notification settings - Fork24
feat: handle windows specific paths in log-path parameter#512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
44e3dfa
toab2f929
Comparebcpeinhardt commentedJun 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I suspect the issue was that claude nuked your lockfile (it likes to do that). Just reverting the lockfile fixed the build. I'll leave passing the test and lint checks up to you :) |
bdc35ba
to281fe1a
Compare281fe1a
tobd9d1ca
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems fine to me, but I am not yet competent to hand out the ✅ of approval so I've asked Asher to take a look 👍
code-asher commentedJun 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It seems like a reasonable change to me since we already use The issue says we are printing Do we know where the escaped chars came from? |
Oh duh it was using |
code-asher commentedJun 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I know what happened, |
@code-asher as in 'unit test'? |
Unit test would be ideal yeah! But I think |
d1289c6
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes:#430