Commitf0740e8

and

authored

Fix version comparison logic for checking wildcard support in "coder ssh" (#446)

Co-authored-by: Benjamin <benjaminpeinhardt@gmail.com>

1 parent4a0f23d commitf0740e8Copy full SHA for f0740e8

File tree

+10

-1

lines changed

+10

-1

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`- Remove agent singleton so that client TLS certificates are reloaded on every API request.`
`8`	`8`	`- Use Axios client to receive event stream so TLS settings are properly applied.`
`9`	`9`	- Set`usage-app=vscode` on`coder ssh` to fix deployment session counting.
	`10`	`+- Fix version comparison logic for checking wildcard support in "coder ssh"`
`10`	`11`
`11`	`12`	`##[v1.4.1](https://github.com/coder/vscode-coder/releases/tag/v1.4.1) (2025-02-19)`
`12`	`13`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,4 +11,12 @@ describe("check version support", () => {`
`11`	`11`	`expect(featureSetForVersion(semver.parse(v)).proxyLogDirectory).toBeTruthy()`
`12`	`12`	`})`
`13`	`13`	`})`
	`14`	`+it("wildcard ssh",()=>{`
	`15`	`+;["v1.3.3+e491217","v2.3.3+e491217"].forEach((v:string)=>{`
	`16`	`+expect(featureSetForVersion(semver.parse(v)).wildcardSSH).toBeFalsy()`
	`17`	`+})`
	`18`	`+;["v2.19.0","v2.19.1","v2.20.0+e491217","v5.0.4+e491217"].forEach((v:string)=>{`
	`19`	`+expect(featureSetForVersion(semver.parse(v)).wildcardSSH).toBeTruthy()`
	`20`	`+})`
	`21`	`+})`
`14`	`22`	`})`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,6 @@ export function featureSetForVersion(version: semver.SemVer \| null): FeatureSet`
`22`	`22`	`// If this check didn't exist, VS Code connections would fail on`
`23`	`23`	`// older versions because of an unknown CLI argument.`
`24`	`24`	`proxyLogDirectory:(version?.compare("2.3.3")\|\|0)>0\|\|version?.prerelease[0]==="devel",`
`25`		`-wildcardSSH:(version?.compare("2.19.0")\|\|0)>0\|\|version?.prerelease[0]==="devel",`
	`25`	`+wildcardSSH:(version ?version.compare("2.19.0"):-1)>=0\|\|version?.prerelease[0]==="devel",`
`26`	`26`	`}`
`27`	`27`	`}`

Comments

(0)