Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitdfd55e1

Browse files
jaggederestclaude
andcommitted
test: add Logger integration tests for commands.ts
- Add tests verifying autologin failures are logged through Logger- Test that manual login errors show dialog instead of logging- Mock makeCoderSdk and needToken to test actual error paths- Use createMockOutputChannelWithLogger factory for consistent test setup- No code changes needed - already compatible via Storage interface- Improves commands.ts coverage from 64.19% to 68.03%🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
1 parent341cc67 commitdfd55e1

File tree

1 file changed

+224
-0
lines changed

1 file changed

+224
-0
lines changed

‎src/commands.test.ts‎

Lines changed: 224 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { describe, it, expect, vi, beforeAll } from "vitest";
44
import*asvscodefrom"vscode";
55
import{Commands}from"./commands";
66
import{Storage}from"./storage";
7+
import{createMockOutputChannelWithLogger}from"./test-helpers";
78
import{OpenableTreeItem}from"./workspacesProvider";
89

910
// Mock dependencies
@@ -13,6 +14,14 @@ vi.mock("./error");
1314
vi.mock("./storage");
1415
vi.mock("./util");
1516
vi.mock("./workspacesProvider");
17+
vi.mock("coder/site/src/api/errors",()=>({
18+
getErrorMessage:vi.fn((error:unknown,defaultMessage:string)=>{
19+
if(errorinstanceofError){
20+
returnerror.message;
21+
}
22+
returndefaultMessage;
23+
}),
24+
}));
1625

1726
beforeAll(()=>{
1827
vi.mock("vscode",()=>{
@@ -1049,4 +1058,219 @@ describe("commands", () => {
10491058
);
10501059
});
10511060
});
1061+
1062+
describe("Logger integration",()=>{
1063+
it("should log autologin failure messages through Logger",async()=>{
1064+
const{ logger}=createMockOutputChannelWithLogger();
1065+
1066+
// Mock makeCoderSdk to return a client that fails auth
1067+
const{ makeCoderSdk}=awaitimport("./api");
1068+
constmockSdkClient={
1069+
getAuthenticatedUser:vi
1070+
.fn()
1071+
.mockRejectedValue(newError("Authentication failed")),
1072+
};
1073+
vi.mocked(makeCoderSdk).mockResolvedValue(mockSdkClientasnever);
1074+
1075+
// Mock needToken to return false so we go into the non-token auth path
1076+
const{ needToken}=awaitimport("./api");
1077+
vi.mocked(needToken).mockReturnValue(false);
1078+
1079+
// Mock getErrorMessage from coder/site
1080+
const{ getErrorMessage}=awaitimport("coder/site/src/api/errors");
1081+
vi.mocked(getErrorMessage).mockReturnValue("Authentication failed");
1082+
1083+
// Mock showErrorMessage for vscodeProposed
1084+
constmockVscodeProposed={
1085+
window:{
1086+
showErrorMessage:vi.fn(),
1087+
},
1088+
}asunknownastypeofvscode;
1089+
1090+
constmockRestClient={
1091+
setHost:vi.fn(),
1092+
setSessionToken:vi.fn(),
1093+
}asunknownasApi;
1094+
1095+
// Create mock Storage that uses Logger
1096+
constmockStorage={
1097+
writeToCoderOutputChannel:vi.fn((msg:string)=>{
1098+
logger.info(msg);
1099+
}),
1100+
setUrl:vi.fn(),
1101+
setSessionToken:vi.fn(),
1102+
configureCli:vi.fn(),
1103+
}asunknownasStorage;
1104+
1105+
constcommands=newCommands(
1106+
mockVscodeProposed,
1107+
mockRestClient,
1108+
mockStorage,
1109+
);
1110+
1111+
// Mock toSafeHost
1112+
const{ toSafeHost}=awaitimport("./util");
1113+
vi.mocked(toSafeHost).mockReturnValue("test.coder.com");
1114+
1115+
// Call login with isAutologin = true (as string in args)
1116+
awaitcommands.login("https://test.coder.com","test-token","","true");
1117+
1118+
// Verify error was logged for autologin
1119+
expect(mockStorage.writeToCoderOutputChannel).toHaveBeenCalledWith(
1120+
"Failed to log in to Coder server: Authentication failed",
1121+
);
1122+
1123+
constlogs=logger.getLogs();
1124+
expect(logs.length).toBe(1);
1125+
expect(logs[0].message).toBe(
1126+
"Failed to log in to Coder server: Authentication failed",
1127+
);
1128+
expect(logs[0].level).toBe("INFO");
1129+
1130+
// Verify showErrorMessage was NOT called (since it's autologin)
1131+
expect(mockVscodeProposed.window.showErrorMessage).not.toHaveBeenCalled();
1132+
});
1133+
1134+
it("should work with Storage instance that has Logger set",async()=>{
1135+
const{ logger}=createMockOutputChannelWithLogger();
1136+
1137+
// Mock makeCoderSdk to return a client that fails auth
1138+
const{ makeCoderSdk}=awaitimport("./api");
1139+
constmockSdkClient={
1140+
getAuthenticatedUser:vi
1141+
.fn()
1142+
.mockRejectedValue(newError("Network error")),
1143+
};
1144+
vi.mocked(makeCoderSdk).mockResolvedValue(mockSdkClientasnever);
1145+
1146+
// Mock needToken to return false
1147+
const{ needToken}=awaitimport("./api");
1148+
vi.mocked(needToken).mockReturnValue(false);
1149+
1150+
// Mock getErrorMessage from coder/site
1151+
const{ getErrorMessage}=awaitimport("coder/site/src/api/errors");
1152+
vi.mocked(getErrorMessage).mockReturnValue("Network error");
1153+
1154+
constmockVscodeProposed={
1155+
window:{
1156+
showErrorMessage:vi.fn(),
1157+
},
1158+
}asunknownastypeofvscode;
1159+
1160+
constmockRestClient={
1161+
setHost:vi.fn(),
1162+
setSessionToken:vi.fn(),
1163+
}asunknownasApi;
1164+
1165+
// Simulate Storage with Logger
1166+
constmockStorage={
1167+
writeToCoderOutputChannel:vi.fn((msg:string)=>{
1168+
logger.error(msg);
1169+
}),
1170+
setUrl:vi.fn(),
1171+
setSessionToken:vi.fn(),
1172+
configureCli:vi.fn(),
1173+
}asunknownasStorage;
1174+
1175+
constcommands=newCommands(
1176+
mockVscodeProposed,
1177+
mockRestClient,
1178+
mockStorage,
1179+
);
1180+
1181+
// Mock toSafeHost
1182+
const{ toSafeHost}=awaitimport("./util");
1183+
vi.mocked(toSafeHost).mockReturnValue("example.coder.com");
1184+
1185+
// Call login with isAutologin = true (as string in args)
1186+
awaitcommands.login(
1187+
"https://example.coder.com",
1188+
"bad-token",
1189+
"",
1190+
"true",
1191+
);
1192+
1193+
// Verify error was logged through Logger
1194+
constlogs=logger.getLogs();
1195+
expect(logs.length).toBeGreaterThan(0);
1196+
consthasExpectedLog=logs.some((log)=>
1197+
log.message.includes("Failed to log in to Coder server: Network error"),
1198+
);
1199+
expect(hasExpectedLog).toBe(true);
1200+
});
1201+
1202+
it("should show error dialog when not autologin",async()=>{
1203+
const{ logger}=createMockOutputChannelWithLogger();
1204+
1205+
// Mock makeCoderSdk to return a client that fails auth
1206+
const{ makeCoderSdk}=awaitimport("./api");
1207+
constmockSdkClient={
1208+
getAuthenticatedUser:vi
1209+
.fn()
1210+
.mockRejectedValue(newError("Invalid token")),
1211+
};
1212+
vi.mocked(makeCoderSdk).mockResolvedValue(mockSdkClientasnever);
1213+
1214+
// Mock needToken to return false
1215+
const{ needToken}=awaitimport("./api");
1216+
vi.mocked(needToken).mockReturnValue(false);
1217+
1218+
// Mock getErrorMessage from coder/site
1219+
const{ getErrorMessage}=awaitimport("coder/site/src/api/errors");
1220+
vi.mocked(getErrorMessage).mockReturnValue("Invalid token");
1221+
1222+
// Mock showErrorMessage for vscodeProposed
1223+
constshowErrorMessageMock=vi.fn();
1224+
constmockVscodeProposed={
1225+
window:{
1226+
showErrorMessage:showErrorMessageMock,
1227+
},
1228+
}asunknownastypeofvscode;
1229+
1230+
constmockRestClient={
1231+
setHost:vi.fn(),
1232+
setSessionToken:vi.fn(),
1233+
}asunknownasApi;
1234+
1235+
// Create mock Storage that uses Logger
1236+
constmockStorage={
1237+
writeToCoderOutputChannel:vi.fn((msg:string)=>{
1238+
logger.info(msg);
1239+
}),
1240+
setUrl:vi.fn(),
1241+
setSessionToken:vi.fn(),
1242+
configureCli:vi.fn(),
1243+
}asunknownasStorage;
1244+
1245+
constcommands=newCommands(
1246+
mockVscodeProposed,
1247+
mockRestClient,
1248+
mockStorage,
1249+
);
1250+
1251+
// Mock toSafeHost
1252+
const{ toSafeHost}=awaitimport("./util");
1253+
vi.mocked(toSafeHost).mockReturnValue("test.coder.com");
1254+
1255+
// Call login with isAutologin = false (default)
1256+
awaitcommands.login("https://test.coder.com","test-token");
1257+
1258+
// Verify error dialog was shown (not logged)
1259+
expect(showErrorMessageMock).toHaveBeenCalledWith(
1260+
"Failed to log in to Coder server",
1261+
{
1262+
detail:"Invalid token",
1263+
modal:true,
1264+
useCustom:true,
1265+
},
1266+
);
1267+
1268+
// Verify writeToCoderOutputChannel was NOT called
1269+
expect(mockStorage.writeToCoderOutputChannel).not.toHaveBeenCalled();
1270+
1271+
// Verify no logs were written
1272+
constlogs=logger.getLogs();
1273+
expect(logs.length).toBe(0);
1274+
});
1275+
});
10521276
});

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp