Commit86de75d

committed

fix: move interval to class level and clear on dispose

1 parent9659dd8 commit86de75dCopy full SHA for 86de75d

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ export class Inbox implements vscode.Disposable {`
`19`	`19`	`#socket:WebSocket`
`20`	`20`	`#messageCount=0`
`21`	`21`	`#workspaceId:string`
	`22`	`+ #memoryInterval:NodeJS.Timeout`
`22`	`23`
`23`	`24`	`constructor(workspace:Workspace,httpAgent:ProxyAgent,restClient:Api,storage:Storage){`
`24`	`25`	`constlogger=getMemoryLogger()`
`@@ -96,12 +97,12 @@ export class Inbox implements vscode.Disposable {`
`96`	`97`	`})`
`97`	`98`
`98`	`99`	`// Log memory stats periodically`
`99`		`-constmemoryInterval=setInterval(`
	`100`	`+this.#memoryInterval=setInterval(`
`100`	`101`	`()=>{`
`101`	`102`	`if(!this.#disposed){`
`102`	`103`	`logger.logMemoryUsage("INBOX_PERIODIC")`
`103`	`104`	`}else{`
`104`		`-clearInterval(memoryInterval)`
	`105`	`+clearInterval(this.#memoryInterval)`
`105`	`106`	`}`
`106`	`107`	`},`
`107`	`108`	`5601000,`
`@@ -118,6 +119,8 @@ export class Inbox implements vscode.Disposable {`
`118`	`119`	`this.#disposed=true`
`119`	`120`	`logger.trackResourceDisposed("InboxWebSocket",this.#workspaceId)`
`120`	`121`	`}`
	`122`	`+`
	`123`	`+clearInterval(this.#memoryInterval)`
`121`	`124`	`}`
`122`	`125`
`123`	`126`	`privatenotifyError(error:unknown){`

Comments

(0)