Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitba41b15

Browse files
committed
feat: implement default preset
Partially addressescoder/coder#18110Signed-off-by: Danny Kopping <dannykopping@gmail.com># Conflicts:#provider/workspace_preset_test.go
1 parent6570400 commitba41b15

File tree

5 files changed

+87
-1
lines changed

5 files changed

+87
-1
lines changed

‎docs/data-sources/workspace_preset.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,16 @@ data "coder_workspace_preset" "example" {
2727
(data.coder_parameter.ami.name) = "ami-xxxxxxxx"
2828
}
2929
}
30+
31+
# Example of a default preset that will be pre-selected for users
32+
data "coder_workspace_preset" "standard" {
33+
name = "Standard"
34+
default = true
35+
parameters = {
36+
(data.coder_parameter.instance_type.name) = "t3.medium"
37+
(data.coder_parameter.region.name) = "us-west-2"
38+
}
39+
}
3040
```
3141

3242
<!-- schema generated by tfplugindocs-->
@@ -38,6 +48,7 @@ data "coder_workspace_preset" "example" {
3848

3949
###Optional
4050

51+
-`default` (Boolean) Whether this preset should be selected by default when creating a workspace. Only one preset per template can be marked as default.
4152
-`parameters` (Map of String) Workspace parameters that will be set by the workspace preset. For simple templates that only need prebuilds, you may define a preset with zero parameters. Because workspace parameters may change between Coder template versions, preset parameters are allowed to define values for parameters that do not exist in the current template version.
4253
-`prebuilds` (Block Set, Max: 1) Configuration for prebuilt workspaces associated with this preset. Coder will maintain a pool of standby workspaces based on this configuration. When a user creates a workspace using this preset, they are assigned a prebuilt workspace instead of waiting for a new one to build. See prebuilt workspace documentation[here](https://coder.com/docs/admin/templates/extending-templates/prebuilt-workspaces.md) (see[below for nested schema](#nestedblock--prebuilds))
4354

‎examples/data-sources/coder_workspace_preset/data-source.tf

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,13 @@ data "coder_workspace_preset" "example" {
1212
(data.coder_parameter.ami.name)="ami-xxxxxxxx"
1313
}
1414
}
15+
16+
# Example of a default preset that will be pre-selected for users
17+
data"coder_workspace_preset""standard" {
18+
name="Standard"
19+
default=true
20+
parameters={
21+
(data.coder_parameter.instance_type.name)="t3.medium"
22+
(data.coder_parameter.region.name)="us-west-2"
23+
}
24+
}

‎integration/test-data-source/main.tf

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ data "coder_parameter" "param" {
2020
icon="param icon"
2121
}
2222
data"coder_workspace_preset""preset" {
23-
name="preset"
23+
name="preset"
24+
default=true
2425
parameters={
2526
(data.coder_parameter.param.name)="preset param value"
2627
}
@@ -64,6 +65,7 @@ locals {
6465
"workspace_parameter.value": data.coder_parameter.param.value,
6566
"workspace_parameter.icon": data.coder_parameter.param.icon,
6667
"workspace_preset.name": data.coder_workspace_preset.preset.name,
68+
"workspace_preset.default":tostring(data.coder_workspace_preset.preset.default),
6769
"workspace_preset.parameters.param": data.coder_workspace_preset.preset.parameters.param,
6870
"workspace_preset.prebuilds.instances":tostring(one(data.coder_workspace_preset.preset.prebuilds).instances),
6971
"workspace_preset.prebuilds.expiration_policy.ttl":tostring(one(one(data.coder_workspace_preset.preset.prebuilds).expiration_policy).ttl),

‎provider/workspace_preset.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ var PrebuildsCRONParser = rbcron.NewParser(rbcron.Minute | rbcron.Hour | rbcron.
1919

2020
typeWorkspacePresetstruct {
2121
Namestring`mapstructure:"name"`
22+
Defaultbool`mapstructure:"default"`
2223
Parametersmap[string]string`mapstructure:"parameters"`
2324
// There should always be only one prebuild block, but Terraform's type system
2425
// still parses them as a slice, so we need to handle it as such. We could use
@@ -92,6 +93,12 @@ func workspacePresetDataSource() *schema.Resource {
9293
Required:true,
9394
ValidateFunc:validation.StringIsNotEmpty,
9495
},
96+
"default": {
97+
Type:schema.TypeBool,
98+
Description:"Whether this preset should be selected by default when creating a workspace. Only one preset per template can be marked as default.",
99+
Optional:true,
100+
Default:false,
101+
},
95102
"parameters": {
96103
Type:schema.TypeMap,
97104
Description:"Workspace parameters that will be set by the workspace preset. For simple templates that only need prebuilds, you may define a preset with zero parameters. Because workspace parameters may change between Coder template versions, preset parameters are allowed to define values for parameters that do not exist in the current template version.",

‎provider/workspace_preset_test.go

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -530,6 +530,62 @@ func TestWorkspacePreset(t *testing.T) {
530530
}`,
531531
ExpectError:regexp.MustCompile(`schedules overlap with each other: schedules overlap: \* 8-18 \* \* 1-5 and \* 18-19 \* \* 5-6`),
532532
},
533+
{
534+
Name:"Default field set to true",
535+
Config:`
536+
data "coder_workspace_preset" "preset_1" {
537+
name = "preset_1"
538+
default = true
539+
parameters = {
540+
"region" = "us-east1-a"
541+
}
542+
}`,
543+
Check:func(state*terraform.State)error {
544+
require.Len(t,state.Modules,1)
545+
require.Len(t,state.Modules[0].Resources,1)
546+
resource:=state.Modules[0].Resources["data.coder_workspace_preset.preset_1"]
547+
require.NotNil(t,resource)
548+
require.Equal(t,resource.Primary.Attributes["default"],"true")
549+
returnnil
550+
},
551+
},
552+
{
553+
Name:"Default field set to false",
554+
Config:`
555+
data "coder_workspace_preset" "preset_1" {
556+
name = "preset_1"
557+
default = false
558+
parameters = {
559+
"region" = "us-east1-a"
560+
}
561+
}`,
562+
Check:func(state*terraform.State)error {
563+
require.Len(t,state.Modules,1)
564+
require.Len(t,state.Modules[0].Resources,1)
565+
resource:=state.Modules[0].Resources["data.coder_workspace_preset.preset_1"]
566+
require.NotNil(t,resource)
567+
require.Equal(t,resource.Primary.Attributes["default"],"false")
568+
returnnil
569+
},
570+
},
571+
{
572+
Name:"Default field not provided (defaults to false)",
573+
Config:`
574+
data "coder_workspace_preset" "preset_1" {
575+
name = "preset_1"
576+
parameters = {
577+
"region" = "us-east1-a"
578+
}
579+
}`,
580+
Check:func(state*terraform.State)error {
581+
require.Len(t,state.Modules,1)
582+
require.Len(t,state.Modules[0].Resources,1)
583+
resource:=state.Modules[0].Resources["data.coder_workspace_preset.preset_1"]
584+
require.NotNil(t,resource)
585+
require.Equal(t,resource.Primary.Attributes["default"],"false")
586+
returnnil
587+
},
588+
},
533589
}
534590

535591
for_,testcase:=rangetestcases {

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp