Commit6dd42ba

committed

fix: avoid calling sendLog in a goroutine on a closed logger

- Calling p.sendLog in a goroutine allows the goroutine to escape the mutex that is being held by a calling function, presenting an opportunity for concurrent read/writes to occur on the map.

1 parentf35ece5 commit6dd42baCopy full SHA for 6dd42ba

File tree

3 files changed

+47

-261

lines changed

3 files changed

+47

-261

lines changed

`‎go.mod`

Lines changed: 8 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,12 +3,15 @@ module github.com/coder/coder-kubernetes-logs`
`3`	`3`	`go1.20`
`4`	`4`
`5`	`5`	`// Required to import the codersdk!`
`6`		`-replacetailscale.com =>github.com/coder/tailscalev1.1.1-0.20230418202606-ed9307cf1b22`
	`6`	`+replacetailscale.com =>github.com/coder/tailscalev0.0.0-20230522123520-74712221d00f`
	`7`	`+`
	`8`	`+replacegvisor.dev/gvisor =>github.com/coder/gvisorv0.0.0-20230714132058-be2e4ac102c3`
`7`	`9`
`8`	`10`	`require (`
`9`	`11`	`cdr.dev/slogv1.5.3`
	`12`	`+github.com/breml/rootcertsv0.2.11`
`10`	`13`	`github.com/coder/coderv0.23.6-0.20230522192129-95839109db09`
`11`		`-github.com/coder/retryv1.3.1-0.20230210155434-e90a2e1e091d`
	`14`	`+github.com/fatih/colorv1.15.0`
`12`	`15`	`github.com/spf13/cobrav1.7.0`
`13`	`16`	`github.com/stretchr/testifyv1.8.2`
`14`	`17`	`github.com/zeebo/assertv1.3.0`
`@@ -32,17 +35,17 @@ require (`
`32`	`35`	`github.com/armon/go-radixv1.0.0// indirect`
`33`	`36`	`github.com/aymanbagabas/go-osc52/v2v2.0.1// indirect`
`34`	`37`	`github.com/beorn7/perksv1.0.1// indirect`
`35`		`-github.com/breml/rootcertsv0.2.11// indirect`
	`38`	`+github.com/bytedance/sonicv1.10.2// indirect`
`36`	`39`	`github.com/cenkalti/backoff/v4v4.2.0// indirect`
`37`	`40`	`github.com/cespare/xxhash/v2v2.2.0// indirect`
`38`	`41`	`github.com/charmbracelet/lipglossv0.7.1// indirect`
	`42`	`+github.com/coder/retryv1.3.1-0.20230210155434-e90a2e1e091d// indirect`
`39`	`43`	`github.com/coder/terraform-provider-coderv0.6.23// indirect`
`40`	`44`	`github.com/coreos/go-iptablesv0.6.0// indirect`
`41`	`45`	`github.com/coreos/go-oidc/v3v3.6.0// indirect`
`42`	`46`	`github.com/davecgh/go-spewv1.1.1// indirect`
`43`	`47`	`github.com/emicklei/go-restful/v3v3.9.0// indirect`
`44`	`48`	`github.com/evanphx/json-patchv4.12.0+incompatible// indirect`
`45`		`-github.com/fatih/colorv1.15.0// indirect`
`46`	`49`	`github.com/fxamacker/cbor/v2v2.4.0// indirect`
`47`	`50`	`github.com/ghodss/yamlv1.0.0// indirect`
`48`	`51`	`github.com/go-chi/chi/v5v5.0.8// indirect`
`@@ -54,6 +57,7 @@ require (`
`54`	`57`	`github.com/go-openapi/jsonreferencev0.20.1// indirect`
`55`	`58`	`github.com/go-openapi/swagv0.22.3// indirect`
`56`	`59`	`github.com/gobwas/globv0.2.3// indirect`
	`60`	`+github.com/goccy/go-jsonv0.10.2// indirect`
`57`	`61`	`github.com/godbus/dbus/v5v5.1.0// indirect`
`58`	`62`	`github.com/gogo/protobufv1.3.2// indirect`
`59`	`63`	`github.com/golang/glogv1.0.0// indirect`
`@@ -175,7 +179,6 @@ require (`
`175`	`179`	`google.golang.org/grpcv1.54.0// indirect`
`176`	`180`	`google.golang.org/protobufv1.30.0// indirect`
`177`	`181`	`gopkg.in/inf.v0v0.9.1// indirect`
`178`		`-gopkg.in/square/go-jose.v2v2.6.0// indirect`
`179`	`182`	`gopkg.in/yaml.v2v2.4.0// indirect`
`180`	`183`	`gopkg.in/yaml.v3v3.0.1// indirect`
`181`	`184`	`gvisor.dev/gvisorv0.0.0-20221203005347-703fd9b7fbc0// indirect`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6dd42ba

File tree

3 files changed

3 files changed

`‎go.mod`

0 commit comments