Commit204f0e3

authored

fix: change dummy workspace logic to include starting and stopping (#107)

fixes#104Includes starting, stopping, pending and unknown (rare!) workspaces as "dummy" grayed workspaces.TBD what we want to do with failed or canceled workspaces.

1 parentbe72f80 commit204f0e3Copy full SHA for 204f0e3

File tree

1 file changed

+18

-1

lines changed

App/ViewModels
- TrayWindowViewModel.cs

1 file changed

+18

-1

lines changed

`‎App/ViewModels/TrayWindowViewModel.cs`

Lines changed: 18 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ private void UpdateFromRpcModel(RpcModel rpcModel)`
`207`	`207`	`// For every stopped workspace that doesn't have any agents, add a`
`208`	`208`	`// dummy agent row.`
`209`	`209`	`foreach(varworkspaceinrpcModel.Workspaces.Where(w=>`
`210`		`-w.Status==Workspace.Types.Status.Stopped&&!workspacesWithAgents.Contains(w.Id)))`
	`210`	`+ShouldShowDummy(w)&&!workspacesWithAgents.Contains(w.Id)))`
`211`	`211`	`{`
`212`	`212`	`if(!Uuid.TryFrom(workspace.Id.Span,outvaruuid))`
`213`	`213`	`continue;`
`@@ -372,4 +372,21 @@ public void Exit()`
`372`	`372`	`{`
`373`	`373`	`_=((App)Application.Current).ExitApplication();`
`374`	`374`	`}`
	`375`	`+`
	`376`	`+privatestaticboolShouldShowDummy(Workspaceworkspace)`
	`377`	`+{`
	`378`	`+switch(workspace.Status)`
	`379`	`+{`
	`380`	`+caseWorkspace.Types.Status.Unknown:`
	`381`	`+caseWorkspace.Types.Status.Pending:`
	`382`	`+caseWorkspace.Types.Status.Starting:`
	`383`	`+caseWorkspace.Types.Status.Stopping:`
	`384`	`+caseWorkspace.Types.Status.Stopped:`
	`385`	`+returntrue;`
	`386`	`+// TODO: should we include and show a different color than Gray for workspaces that are`
	`387`	`+// failed, canceled or deleting?`
	`388`	`+default:`
	`389`	`+returnfalse;`
	`390`	`+}`
	`391`	`+}`
`375`	`392`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit204f0e3

File tree

1 file changed

1 file changed

`‎App/ViewModels/TrayWindowViewModel.cs`

0 commit comments