Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: show when workspace apps are loading#163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/workspace-apps-loading
May 22, 2025

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMay 20, 2025•
edited
Loading

Also switches all the stock ProgressViews to our new CircularProgressView

inaction.mov
mocked.mov

@ethanndicksonethanndickson changed the titlefeat: show when workspace apps are loading ethan/workspace-apps-loadingfeat: show when workspace apps are loadingMay 20, 2025
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMay 20, 2025•
edited
Loading

@ethanndicksonethanndickson marked this pull request as ready for reviewMay 20, 2025 04:20
@ethanndicksonethanndickson requested review fromCopilot anddeansheather and removed request forCopilotMay 20, 2025 04:42
Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces a loading indicator for workspace apps and replaces all instances ofProgressView with the newCircularProgressView.

  • AddsloadingApps state and displays a circular spinner while apps load
  • Swaps outProgressView in multiple views forCircularProgressView with custom sizing
  • Ensures the spinner is hidden once loading completes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
Views/VPN/WorkspaceAppIcon.swiftReplaced smallProgressView with circular spinner
Views/VPN/VPNMenuItem.swiftAddedloadingApps flag and conditional spinner
Views/FileSync/FileSyncSessionModal.swiftReplaced modalProgressView with circular spinner
Views/FileSync/FilePicker.swiftReplaced file-treeProgressView with circular spinner
Views/FileSync/FilePicker.swift (inFilePickerEntry)Replaced entry loaderProgressView with circular spinner

@ethanndicksonethanndicksonforce-pushed theethan/workspace-apps-loading branch from06b1ca3 to8b30a75CompareMay 22, 2025 02:13
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMay 22, 2025•
edited
Loading

Merge activity

  • May 22, 3:59 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • May 22, 4:01 AM UTC:Graphite rebased this pull request as part of a merge.
  • May 22, 4:02 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/xpc-progress tographite-base/163May 22, 2025 04:00
@ethanndicksonethanndickson changed the base branch fromgraphite-base/163 tomainMay 22, 2025 04:00
@ethanndicksonethanndicksonforce-pushed theethan/workspace-apps-loading branch from8b30a75 toa820d5aCompareMay 22, 2025 04:01
@ethanndicksonethanndickson merged commit117d8fd intomainMay 22, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/workspace-apps-loading branchMay 22, 2025 04:02
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp