- Notifications
You must be signed in to change notification settings - Fork3
chore: set 'stop VPN on quit' setting to true by default#155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
guard object(forKey: key) != nil else { | ||
return nil | ||
} | ||
return bool(forKey: key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't understand why this API doesn't already just return aBool?
. It is quite silly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ethanndickson commentedMay 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
37d7e35
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
It's fair to assume if you're closing Coder Desktop, you want Coder Connect to stop, so this is the default behaviour.
Tailscale also stops their VPN when quitting the app, even though it works fine with the app closed.
This won't have any effect on existing installations, this only sets the default value for new installations.