Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: set 'stop VPN on quit' setting to true by default#155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/stop-vpn-on-quit-default-true
May 14, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMay 8, 2025
edited
Loading

It's fair to assume if you're closing Coder Desktop, you want Coder Connect to stop, so this is the default behaviour.

Tailscale also stops their VPN when quitting the app, even though it works fine with the app closed.

This won't have any effect on existing installations, this only sets the default value for new installations.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewMay 8, 2025 04:40
guard object(forKey: key) != nil else {
return nil
}
return bool(forKey: key)
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't understand why this API doesn't already just return aBool?. It is quite silly.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

imageI'm also not the first to do this...

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedMay 14, 2025
edited
Loading

Merge activity

  • May 14, 3:21 AM EDT: A user started a stack merge that includes this pull request viaGraphite.
  • May 14, 3:22 AM EDT:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit37d7e35 intomainMay 14, 2025
4 checks passed
@ethanndicksonethanndickson deleted the ethan/stop-vpn-on-quit-default-true branchMay 14, 2025 07:22
@ethanndicksonethanndickson self-assigned thisMay 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ibetitsmikeibetitsmikeibetitsmike approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@ibetitsmike

[8]ページ先頭

©2009-2025 Movatter.jp