- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: migrate autocomplete component#21323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| getOptionLabel={(option)=>option.email} | ||
| onOpen={()=>{ | ||
| setOpen(true); | ||
| setFilter(value?.email??""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Im not sure why setFilter was previously set tovalue?.email, this made it very difficult to choose a different value for the owner on the Create workspace page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For example, try out the existing owner autocomplete dropdown vs the one in this PR, I cant think of a reason why the existing one is difficult to use.
Uh oh!
There was an error while loading.Please reload this page.
Also, adds built-in required and error text