- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: isolate keyring usage by parallel test processes#21256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This change ensures keyring tests that utilize the real OS keyring usecredentials that are isolated by process ID so that parallel test processesdo not access the same credentials.
| iferr!=nil { | ||
| t.Fatal(err) | ||
| } | ||
| returnfmt.Sprintf("%s_%v_%d",t.Name(),time.Now().UnixNano(),n) |
ethanndicksonDec 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The flake was on Windows, and the Windows clock does have infamously poor precision (https://github.com/search?q=org%3Acoder+windows+clock+flake&type=issues, so I'm inclined to believe your hypothesis of multiple instances of the job running on the same Windows machine.
7ecfd1a intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This change ensures keyring tests that utilize the real OS keyring use credentials that are isolated by process ID so that parallel test processes do not access the same credentials.
coder/internal#1192