- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: improve AI Bridge request logs UI/UX#21252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| <> | ||
| <TableRow | ||
| className="select-none cursor-pointer hover:bg-surface-secondary" | ||
| className="select-none cursor-pointer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Need to have a discussion here if we still want to have ahover: effect. It directly clashes with the<Badge /> backgrounds. I can't say I love that.. YOMV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's stick to the default hover style for tables and only highlight the borders (e.g. see the workspace list)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
matifali left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am not sure if showingInitiator is a good idea in UI. We do not use this word anywhere in Coder UI, and it may confuse users on what is this new term,
@chrifro and@dannykopping for your thoughts?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
site/src/pages/AIBridgePage/RequestLogsPage/RequestLogsRow/RequestLogsRow.tsxShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| constcustomisedDateLocale:Intl.DateTimeFormatOptions={ | ||
| // Hide the year from the date | ||
| year:undefined, | ||
| // Show the month as a short name | ||
| month:"short", | ||
| day:"numeric", | ||
| hour:"2-digit", | ||
| minute:"2-digit", | ||
| second:"2-digit", | ||
| hour12:true, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need to decide if we're going to standardise against this, feels strange to have it just in the<RequestLogsPageView />. YOMV but I don't love the fact that we're no longer just relying on the browser to decide the output. Especially enforcing 12 hour time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree we need to standardise it. What are the downside of not using the browser to decide the output? How do other companies solve this?
My take: The date format of e.g. Dec 15, highly increases readability through different local standards. So I'd very much like to make that the new standard. For the time, I'm less opinionated and we can follow whatever works best on the technical side. Does that work for you? :)
Once we agreed, could you open a follow-up issue to update the change globally?
site/src/pages/AIBridgePage/RequestLogsPage/RequestLogsRow/RequestLogsRow.tsxShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
chrifro commentedDec 15, 2025
agreed. I'm also in favor of keeping "users" for consistency |
dannykopping commentedDec 15, 2025
The terminology was very carefully chosen. We're leaving the door open for the future when non-human actors might initiate requests. Let's please keep it as initiator. |
matifali commentedDec 15, 2025
OK, I am OK with this. I was mainly concerned about introducing a new term without describing what it means. Let's also document this and add a tooltip with the link. This will help users discover it on their own without sending us questions. |
Uh oh!
There was an error while loading.Please reload this page.
Closes#21052 and is related to#21218
This pull request implements a bunch of changes the team requested to improve the overall user experience when navigating to the Request Logs page. Since these are mostly UI changes, screenshots do a much better job of showing what's different than me trying to explain everything in words, so I've included them below.
Warning
More globally we've changed how we're rendering
<PaginationHeader />, therefore we've renamed it to<PaginationAmount />. This will effect multiple layouts however its a global improvement we're intentionally looking to make.Preview
Changes
MMM(i.eDec).namefield falling back on.username.text-xstotext-smto increase overall legibility globally.<Badge />and gives longer names a chance to render.<Badge />alongside their icons.<Badge />-group alongside truncation (when necessary).5is rendered with the proper name being visible on hover (for use if truncated).Showing X of Xcounts to the bottom of the tables (effects other components outside of AI Bridge).Providerfilter.<dt>element with the badgeExperimentalHandler