- Notifications
You must be signed in to change notification settings - Fork947
feat: add workspace_apps configuration to control apps in workspace table#18922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge9 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+1,114 −1,982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Updated the button labels on the /workspaces page to clearly indicate that VS Code opens in the browser, matching the UI mockup provided.
…pace table- Added workspace_apps field to terraform coder_agent resource- Updated proto definition to include workspace_apps- Modified frontend WorkspaceApps component to respect configured apps- Allows specifying which apps (built-in and custom) appear in the workspace table- Maximum of 4 apps displayed, in the order specified
- Add database migration for workspace_apps column- Update SQL queries to include workspace_apps- Update provisioner server to pass workspace_apps from terraform- Still needs: database code regeneration and API updates
Add workspace_apps configuration to control which apps appear in workspace table:- Add database migration for workspace_apps column- Update WorkspaceAgent struct to include workspace_apps field- Update SQL queries to handle workspace_apps- Add comprehensive tests for the new functionality- Add documentation with examplesThis allows administrators to configure via Terraform which appsappear as action buttons in the workspace table while maintainingbackward compatibility.
0c281d9 toeb77a5eCompareThis ensures the generated database code includes the workspace_apps fieldneeded for the feature to compile properly.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure which apps appear in the workspace table on the /workspaces page via terraform.
Changes
workspace_appsfield to thecoder_agentterraform resourceUsage Example
Implementation Notes
TODO
Requested by@jacqueline in Slack.