Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(site): revamp UI for batch-updating workspaces#18895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Parkreiner wants to merge7 commits intomes/batch-update-01
base:mes/batch-update-01
Choose a base branch
Loading
frommes/batch-update-02

Conversation

Parkreiner
Copy link
Member

@ParkreinerParkreiner commentedJul 16, 2025•
edited
Loading

Closes#18879
Builds on#18895

Changes made

  • DeletedBatchUpdateConfirmation component, replacing it withBatchUpdateModalForm
  • Added stories for the new component, trying to capture every variant I could think of

Screenshots

image

Notes

  • There's too many problems to list, but look at the issue to see all the problems we had with the old implementation
  • It's definitely helpful to look at the stories to see all the things the component is meant to cover

@ParkreinerParkreiner self-assigned thisJul 16, 2025
isLoading={batchActions.isProcessing}
onClose={() => setActiveBatchAction(undefined)}
onConfirm={async () => {
workspacesToUpdate={checkedWorkspaces}
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Renamed prop because I don't think that a component should need to be aware of how its parent chooses to represent workspace selections

@Parkreiner
Copy link
MemberAuthor

@aslilac I don't think there's a good way to ping you specifically now that you're a code owner, but I was hoping I could have you review this PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aslilacaslilacAwaiting requested review from aslilacaslilac is a code owner

Assignees

@ParkreinerParkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp