- Notifications
You must be signed in to change notification settings - Fork948
fix(site): tighten interface design for various frontend utility functions#18894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Parkreiner wants to merge15 commits intomainChoose a base branch frommes/batch-update-01
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+312 −192
Open
Changes from1 commit
Commits
Show all changes
15 commits Select commitHold shift + click to select a range
bb05088
refactor: centralize storybook queries key
Parkreinera119d70
refactor: centralize template version key prefix
Parkreiner5dc67cf
refactor: remove JSX extension from batch actions
Parkreiner4c77bff
fix: update API design of various utility hooks
Parkreiner4833ae1
fix: remove promise race conditions for batch utilities
Parkreinerb8d92fa
fix: decouple component props from one another
Parkreiner1662a55
fix: apply biome fixes
Parkreinere326414
refactor: remove more bad coupling
Parkreinercc00106
fix: format
Parkreiner7304644
fix: update call site mismatch
Parkreinerb512e18
fix: update import
Parkreinercb92b79
fix: update Filter logic to account for fallback filter
Parkreiner86d19b8
docs: add comment about wonky code
Parkreiner330d91d
fix: get workspace tests passing
Parkreinerfb9d8f2
fix: update biome again
ParkreinerFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
fix: update Filter logic to account for fallback filter
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitcb92b79abe31b5c5513124cc019d466a0f0e32d7
There are no files selected for viewing
7 changes: 3 additions & 4 deletionssite/src/components/Filter/Filter.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletionsite/src/pages/AuditPage/AuditPage.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.