Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(site): tighten interface design for various frontend utility functions#18894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Parkreiner wants to merge15 commits intomain
base:main
Choose a base branch
Loading
frommes/batch-update-01
Open
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
15 commits
Select commitHold shift + click to select a range
bb05088
refactor: centralize storybook queries key
ParkreinerJul 16, 2025
a119d70
refactor: centralize template version key prefix
ParkreinerJul 16, 2025
5dc67cf
refactor: remove JSX extension from batch actions
ParkreinerJul 16, 2025
4c77bff
fix: update API design of various utility hooks
ParkreinerJul 16, 2025
4833ae1
fix: remove promise race conditions for batch utilities
ParkreinerJul 16, 2025
b8d92fa
fix: decouple component props from one another
ParkreinerJul 16, 2025
1662a55
fix: apply biome fixes
ParkreinerJul 16, 2025
e326414
refactor: remove more bad coupling
ParkreinerJul 16, 2025
cc00106
fix: format
ParkreinerJul 16, 2025
7304644
fix: update call site mismatch
ParkreinerJul 16, 2025
b512e18
fix: update import
ParkreinerJul 16, 2025
cb92b79
fix: update Filter logic to account for fallback filter
ParkreinerJul 16, 2025
86d19b8
docs: add comment about wonky code
ParkreinerJul 16, 2025
330d91d
fix: get workspace tests passing
ParkreinerJul 16, 2025
fb9d8f2
fix: update biome again
ParkreinerJul 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
fix: update Filter logic to account for fallback filter
  • Loading branch information
@Parkreiner
Parkreiner committedJul 16, 2025
commitcb92b79abe31b5c5513124cc019d466a0f0e32d7
7 changes: 3 additions & 4 deletionssite/src/components/Filter/Filter.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,14 +57,13 @@ export const useFilter = ({
const update = (newValues: string | FilterValues) => {
const serialized =
typeof newValues === "string" ? newValues : stringifyFilter(newValues);
const noUpdateNeeded =searchParams.get(useFilterParamsKey) === serialized;
const noUpdateNeeded =query === serialized;
if (noUpdateNeeded) {
return;
}

const copy = new URLSearchParams(searchParams);
copy.set(useFilterParamsKey, serialized);
onSearchParamsChange(copy);
searchParams.set(useFilterParamsKey, serialized);
onSearchParamsChange(searchParams);
onUpdate?.(serialized);
};

Expand Down
3 changes: 2 additions & 1 deletionsite/src/pages/AuditPage/AuditPage.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
import { server } from "testHelpers/server";
import * as CreateDayString from "utils/createDayString";
import AuditPage from "./AuditPage";
import type { AuditLogsRequest } from "api/typesGenerated";

interface RenderPageOptions {
filter?: string;
Expand DownExpand Up@@ -106,7 +107,7 @@ describe("AuditPage", () => {
await userEvent.type(filterField, query);

await waitFor(() =>
expect(getAuditLogsSpy).toBeCalledWith({
expect(getAuditLogsSpy).toHaveBeenCalledWith<[AuditLogsRequest]>({
limit: DEFAULT_RECORDS_PER_PAGE,
offset: 0,
q: query,
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp