Jul 15, 2025 · Jul 15, 2025 · Jul 15, 2025 · Jul 15, 2025 · Jul 15, 2025 · Jul 15, 2025
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
 return job, nil
 }

 func (q *querier) GetProvisionerJobLogSize(ctx context.Context, jobID uuid.UUID) (interface{}, error) {
 _, err := q.GetProvisionerJobByID(ctx, jobID)
 if err != nil {
 return nil, err
 }
 return q.db.GetProvisionerJobLogSize(ctx, jobID)
 }

 func (q *querier) GetProvisionerJobTimingsByJobID(ctx context.Context, jobID uuid.UUID) ([]database.ProvisionerJobTiming, error) {
 _, err := q.GetProvisionerJobByID(ctx, jobID)
 if err != nil {
 return q.db.UpdateProvisionerJobByID(ctx, arg)
 }

 func (q *querier) UpdateProvisionerJobLogsLength(ctx context.Context, arg database.UpdateProvisionerJobLogsLengthParams) error {
 // Not sure what the rbac should be here, going with this for now
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceProvisionerJobs); err != nil {
 return err
 }
 return q.db.UpdateProvisionerJobLogsLength(ctx, arg)
 }

 func (q *querier) UpdateProvisionerJobLogsOverflowed(ctx context.Context, arg database.UpdateProvisionerJobLogsOverflowedParams) error {
 // Not sure what the rbac should be here, going with this for now
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceProvisionerJobs); err != nil {
 return err
 }
 return q.db.UpdateProvisionerJobLogsOverflowed(ctx, arg)
 }

 func (q *querier) UpdateProvisionerJobWithCancelByID(ctx context.Context, arg database.UpdateProvisionerJobWithCancelByIDParams) error {
 // TODO: Remove this once we have a proper rbac check for provisioner jobs.
 // Details in https://github.com/coder/coder/issues/16160
diff --git a/coderd/database/dbmetrics/querymetrics.go b/coderd/database/dbmetrics/querymetrics.go
diff --git a/coderd/database/dbmock/dbmock.go b/coderd/database/dbmock/dbmock.go
diff --git a/coderd/database/dump.sql b/coderd/database/dump.sql
diff --git a/coderd/database/errors.go b/coderd/database/errors.go

 return false
 }

 func IsProvisionerJobLogsLimitError(err error) bool {
 var pqErr *pq.Error
 if errors.As(err, &pqErr) {
 return pqErr.Constraint == "max_provisioner_logs_length" && pqErr.Table == "provisioner_jobs"
 }
 return false
 }
diff --git a/coderd/database/migrations/000349_add_provisioner_logs_overflowed.down.sql b/coderd/database/migrations/000349_add_provisioner_logs_overflowed.down.sql
 ALTER TABLE provisioner_jobs DROP COLUMN logs_length;
 ALTER TABLE provisioner_jobs DROP COLUMN logs_overflowed;
diff --git a/coderd/database/migrations/000349_add_provisioner_logs_overflowed.up.sql b/coderd/database/migrations/000349_add_provisioner_logs_overflowed.up.sql
 -- Add logs length tracking and overflow flag, similar to workspace agents
  ALTER TABLE provisioner_jobs ADD COLUMN logs_length integer NOT NULL DEFAULT 0 CONSTRAINT max_provisioner_logs_length CHECK (logs_length <= 1048576);
  ALTER TABLE provisioner_jobs ADD COLUMN logs_overflowed boolean NOT NULL DEFAULT false;

  COMMENT ON COLUMN provisioner_jobs.logs_length IS 'Total length of provisioner logs';
  COMMENT ON COLUMN provisioner_jobs.logs_overflowed IS 'Whether the provisioner logs overflowed in length';
diff --git a/coderd/database/models.go b/coderd/database/models.go
diff --git a/coderd/database/querier.go b/coderd/database/querier.go
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2486,6 +2486,14 @@ func (q *querier) GetProvisionerJobByIDForUpdate(ctx context.Context, id uuid.UU
		return job, nil
		}

		func (q *querier) GetProvisionerJobLogSize(ctx context.Context, jobID uuid.UUID) (interface{}, error) {
		_, err := q.GetProvisionerJobByID(ctx, jobID)
		if err != nil {
		return nil, err
		}
		return q.db.GetProvisionerJobLogSize(ctx, jobID)
		}

		func (q *querier) GetProvisionerJobTimingsByJobID(ctx context.Context, jobID uuid.UUID) ([]database.ProvisionerJobTiming, error) {
		_, err := q.GetProvisionerJobByID(ctx, jobID)
		if err != nil {
Expand DownExpand Up		@@ -4431,6 +4439,22 @@ func (q *querier) UpdateProvisionerJobByID(ctx context.Context, arg database.Upd
		return q.db.UpdateProvisionerJobByID(ctx, arg)
		}

		func (q *querier) UpdateProvisionerJobLogsLength(ctx context.Context, arg database.UpdateProvisionerJobLogsLengthParams) error {
		// Not sure what the rbac should be here, going with this for now
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceProvisionerJobs); err != nil {
		return err
		}
		return q.db.UpdateProvisionerJobLogsLength(ctx, arg)
		}

		func (q *querier) UpdateProvisionerJobLogsOverflowed(ctx context.Context, arg database.UpdateProvisionerJobLogsOverflowedParams) error {
		// Not sure what the rbac should be here, going with this for now
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceProvisionerJobs); err != nil {
		return err
		}
		return q.db.UpdateProvisionerJobLogsOverflowed(ctx, arg)
		}

		func (q *querier) UpdateProvisionerJobWithCancelByID(ctx context.Context, arg database.UpdateProvisionerJobWithCancelByIDParams) error {
		// TODO: Remove this once we have a proper rbac check for provisioner jobs.
		// Details in https://github.com/coder/coder/issues/16160
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -79,3 +79,11 @@ func IsWorkspaceAgentLogsLimitError(err error) bool {

		return false
		}

		func IsProvisionerJobLogsLimitError(err error) bool {
		var pqErr *pq.Error
		if errors.As(err, &pqErr) {
		return pqErr.Constraint == "max_provisioner_logs_length" && pqErr.Table == "provisioner_jobs"
		}
		return false
		}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		ALTER TABLE provisioner_jobs DROP COLUMN logs_length;
		ALTER TABLE provisioner_jobs DROP COLUMN logs_overflowed;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,6 @@
		-- Add logs length tracking and overflow flag, similar to workspace agents
		ALTER TABLE provisioner_jobs ADD COLUMN logs_length integer NOT NULL DEFAULT 0 CONSTRAINT max_provisioner_logs_length CHECK (logs_length <= 1048576);
		ALTER TABLE provisioner_jobs ADD COLUMN logs_overflowed boolean NOT NULL DEFAULT false;

		COMMENT ON COLUMN provisioner_jobs.logs_length IS 'Total length of provisioner logs';
		COMMENT ON COLUMN provisioner_jobs.logs_overflowed IS 'Whether the provisioner logs overflowed in length';